Fix undefined error for 'isMac' #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens to me while typing and its very annoying. I find it strange that nobody else spotted it.
whoops
|
It has been spotted. And I really would like to see this merged |
|
@f Any way we can get these pull requests merged in (this, and either of the open ones dealing with the 'K' key binding)? Since this is a dependency for the term2 package for Atom, it'd be awesome if we didn't have to deal with manual patching. That said - thanks for putting in the time you have for maintaining this, no matter when you get to it. Helpful to all of us atom users. |
|
its up to @f |
|
@f Any chance we could get this merged? Again, thanks for all the great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens to me while typing and its very annoying. I find it strange that nobody else spotted it.