Fix bpfilter.pc debug link flags#15
Merged
Merged
Conversation
When building in debug mode, bpfilter (and libbpfilter) is linked to asan and ubsan. However, those link flags were not reflected in bpfilter.pc, leading to build failure in downstream projects. Use a generator expression to add -fsanitize=address and -fsanitize=undefined to bpfilter.pc in debug mode. Signed-off-by: Quentin Deslandes <qde@naccy.de>
qdeslandes
force-pushed
the
fix_pkgconfig_ldflags_debug
branch
from
ad0ee2b to
3260b60
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=======================================
Coverage 10.70% 10.70%
=======================================
Files 33 33
Lines 2260 2260
=======================================
Hits 242 242
Misses 2018 2018 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building in debug mode, bpfilter (and libbpfilter) is linked to asan and ubsan. However, those link flags are not reflected in
bpfilter.pc, leading to build failure in downstream projects.Use a generator expression to add
-fsanitize=addressand-fsanitize=undefinedtobpfilter.pcin debug mode.