Skip to content

Commit 1762ddb

Browse files
Simon Schellaertfacebook-github-bot
authored andcommitted
Fix comment about dex compression
Summary: I introduced a new dex compression method (`raw_subdir`) with corresponding description in D82302583. I just realized I messed up the numbering in the comment: https://www.internalfb.com/code/fbsource/[a018a61513e801b70447025a195e0f20135f2261]/fbcode/buck2/prelude/android/dex_rules.bzl?lines=37%2C39%2C41%2C46%2C48%2C50 We have 5 compression methods numbered 1, 2, 3, 4, 5 — not 4 compression methods numbered 1, 2, 2, 3, 4. The behavior is unchanged, this merely fixes the comment. Differential Revision: D82372774 fbshipit-source-id: ff1996b1af371b8f640a00490ea6e00bb68c9d44
1 parent 693d97d commit 1762ddb

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

android/dex_rules.bzl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ load("@prelude//utils:utils.bzl", "flatten")
3434
#
3535
# The primary DEX is always stored in the root directory of the APK as `classes.dex`.
3636
#
37-
# We have 4 different ways of storing our secondary DEX files, which are specified via the
37+
# We have 5 different ways of storing our secondary DEX files, which are specified via the
3838
# `dex_compression` attribute:
3939
# 1) `raw` compression. This means that we create `classes2.dex`, `classes3.dex`, ...,
4040
# `classesN.dex` and store each of them in the root directory of the APK.
@@ -43,11 +43,11 @@ load("@prelude//utils:utils.bzl", "flatten")
4343
# the sense that secondary DEX files are included in the APK without
4444
# additional compression. However, those raw DEXes are written to the
4545
# secondary dex subdirectory instead of to the root directory of the APK.
46-
# 2) `jar` compression. For each secondary DEX file, we put a `classes.dex` entry into a
46+
# 3) `jar` compression. For each secondary DEX file, we put a `classes.dex` entry into a
4747
# JAR file, and store it as an asset at `assets/secondary-program-dex-jars/secondary-I.dex.jar`
48-
# 3) `xz` compression. This is the same as `jar` compression, except that we run `xz` on the
48+
# 4) `xz` compression. This is the same as `jar` compression, except that we run `xz` on the
4949
# JAR file to produce `assets/secondary-program-dex-jars/secondary-I.dex.jar.xz`.
50-
# 4) `xzs` compression. We do the same as `jar` compression, then concatenate all the jars
50+
# 5) `xzs` compression. We do the same as `jar` compression, then concatenate all the jars
5151
# together and do `xz` compression on the result to produce a single
5252
# `assets/secondary-program-dex-jars/secondary.dex.jar.xzs`.
5353
#

0 commit comments

Comments
 (0)