propagate the debug binaries through ApplePackageInfo

rmaz · meta-codesync[bot] · commit 1ff568e87067 · 2026-05-22T13:23:23.000-07:00
Summary: Propagate the list of unstripped binaries to the ApplePackageInfo provider. This will be used to create debug info based on the binary symbol tables.

Reviewed By: cosminconst

Differential Revision: D105966238

fbshipit-source-id: 897a738e0fbea2bd056e422dd471926232055801
diff --git a/apple/apple_package.bzl b/apple/apple_package.bzl
@@ -68,6 +68,7 @@ def apple_package_impl(ctx: AnalysisContext) -> list[Provider]:
             dsyms = ctx.attrs.bundle[AppleDebuggableInfo].dsyms,
             info_plist = ctx.attrs.bundle[AppleInfoPlistInfo].info_plist,
             linker_maps = ctx.attrs.bundle[AppleBundleLinkerMapInfo].linker_maps,
+            unstripped_binaries = ctx.attrs.bundle[AppleDebuggableInfo].binaries,
         ),
     ]
 
diff --git a/apple/apple_package_types.bzl b/apple/apple_package_types.bzl
@@ -17,5 +17,6 @@ ApplePackageInfo = provider(
         "linker_maps": provider_field(list[Artifact]),
         "name": provider_field(str),
         "package": provider_field(Artifact),
+        "unstripped_binaries": provider_field(list[Artifact]),
     },
 )

Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,7 @@ def apple_package_impl(ctx: AnalysisContext) -> list[Provider]:`
`68`	`68`	`dsyms = ctx.attrs.bundle[AppleDebuggableInfo].dsyms,`
`69`	`69`	`info_plist = ctx.attrs.bundle[AppleInfoPlistInfo].info_plist,`
`70`	`70`	`linker_maps = ctx.attrs.bundle[AppleBundleLinkerMapInfo].linker_maps,`
	`71`	`+ unstripped_binaries = ctx.attrs.bundle[AppleDebuggableInfo].binaries,`
`71`	`72`	`),`
`72`	`73`	`]`
`73`	`74`
Original file line number	Diff line number	Diff line change
`@@ -17,5 +17,6 @@ ApplePackageInfo = provider(`
`17`	`17`	`"linker_maps": provider_field(list[Artifact]),`
`18`	`18`	`"name": provider_field(str),`
`19`	`19`	`"package": provider_field(Artifact),`
	`20`	`+ "unstripped_binaries": provider_field(list[Artifact]),`
`20`	`21`	`},`
`21`	`22`	`)`