Skip to content

Commit 35c6533

Browse files
bobyangyffacebook-github-bot
authored andcommitted
Move materialization context creation out of ensure_artifact
Summary: more reusable Reviewed By: krallin Differential Revision: D36531840 fbshipit-source-id: ef16b9bf44c4c70c979f7a2e309d556b8202bf5f
1 parent 7ed1faf commit 35c6533

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

cli/bin/bxl.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,11 @@ async fn async_main(
249249
.eval_bxl(BxlKey::new(bxl_label.clone(), bxl_args))
250250
.await?;
251251

252-
let build_result = ensure_artifacts(&dice, result).await;
252+
let materialization_ctx = MaterializationContext::Materialize {
253+
map: Arc::new(Default::default()),
254+
force: false,
255+
};
256+
let build_result = ensure_artifacts(&dice, &materialization_ctx, result).await;
253257

254258
match build_result {
255259
None => {}
@@ -333,13 +337,9 @@ async fn async_main(
333337

334338
async fn ensure_artifacts(
335339
ctx: &DiceComputations,
340+
materialization_ctx: &MaterializationContext,
336341
bxl_result: Arc<BxlResult>,
337342
) -> Option<Vec<BuildTargetResult>> {
338-
let materialization_ctx = MaterializationContext::Materialize {
339-
map: Arc::new(Default::default()),
340-
force: false,
341-
};
342-
343343
match &*bxl_result {
344344
BxlResult::None { .. } => None,
345345
BxlResult::BuildsArtifacts {
@@ -366,7 +366,7 @@ async fn ensure_artifacts(
366366
values: materialize_artifact_group(
367367
ctx,
368368
&ArtifactGroup::Artifact(artifact.dupe()),
369-
&materialization_ctx,
369+
materialization_ctx,
370370
)
371371
.await?,
372372
provider_type: BuildProviderType::DefaultOther,
@@ -407,7 +407,7 @@ async fn ensure_artifacts(
407407
values: materialize_artifact_group(
408408
ctx,
409409
&ArtifactGroup::Artifact(a.dupe()),
410-
&materialization_ctx,
410+
materialization_ctx,
411411
)
412412
.await?,
413413
provider_type: BuildProviderType::DefaultOther,

0 commit comments

Comments
 (0)