-
-
Notifications
You must be signed in to change notification settings - Fork 27k
Dev build doesn't include Set polyfill #3275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Already there is pending PR for this. #3200 |
But I did add those two polyfills and dev didn't work, only prod. Is there any reason for the polyfills not loading on dev? |
We don't intend to include a |
@Ismael include babel-poly-fill in public/index.html as a script tag, that will solve most of your problems. |
React 16 requires Set.
I'm developing for an older browser which does not have Set. In production mode, the project works. In dev mode, I get an Set is undefined error.
I'm importing babel-polyfill at the top of my index.js, but that doesn't work.
I tried importing core-js/es6/set directly and didn't work either.
How can I make sure the dev build includes support for legacy browsers?
Also, maybe you should include Set by default in the polyfills as this is required by React 16?
https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#supported-language-features-and-polyfills
The text was updated successfully, but these errors were encountered: