-
-
Notifications
You must be signed in to change notification settings - Fork 27k
HMR not working when fixing errors #6694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm asking because I honestly don't know: does CRA even claim to support hot module reloading? I'm not sure anyone wants to devote time to an issue for a feature that isn't officially supported. |
There is already a PR for this #2304 and I missed it. |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
This issue has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. |
Is this a bug report?
Yes.
Did you try recovering your dependencies?
Yes
Which terms did you search for in User Guide?
HMR, hot-reloading
Environment
"react-scripts": "2.1.8"
Steps to Reproduce
render
method withmodule.hot.accept(
.throw new Error('boo')
somewhere.Expected Behavior
The page should not hard-reload.
Actual Behavior
The page is hard-reloading.
Here is the full video https://take.ms/DjMTV. You can see that console logs are disappearing, and it means hard-reload.
HMR works correctly if I update something without errors.
redbox-react works correctly, and it's possible to implement HMR on errors, but CRA uses a different library.
Reproducible Demo
Repo
The text was updated successfully, but these errors were encountered: