Skip to content

Polyfills and browser compatibility (Affecting SEO) #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arunoda opened this issue Sep 25, 2016 · 5 comments
Closed

Polyfills and browser compatibility (Affecting SEO) #746

arunoda opened this issue Sep 25, 2016 · 5 comments

Comments

@arunoda
Copy link
Contributor

arunoda commented Sep 25, 2016

Description

I had issues getting getstorybook.io listed on Google, because it doesn't render anything on Google's Fetch and Render feature.

I so I dig into the issue and it was Array.find() couldn't find on Google's browser env. Since Google's Fetch and Render didn't provide console.log output I had to debug this for more than 4 hours doing a lot of trial and error stuff.

Why?

This is happening because we don't use babel-polyfill or any other polyfill or shims.

What we can do?

I can understand the reason behind not using polyfills. But we should document clearly on why we do it and how to add some polyfills.

I simply added following line to src/index.js and everything works fine.

import from 'airbnb-js-shims';
@thangngoc89
Copy link
Contributor

I use Polyfill CDN for this https://polyfill.io/v2/docs/

It's fast and easy.

@itsdouges
Copy link

Hey! This worked great, you're my hero :-).

@gaearon
Copy link
Contributor

gaearon commented Jan 8, 2018

We have docs both on supported browsers and polyfills so I feel this is good to go.

@gaearon gaearon closed this as completed Jan 8, 2018
@rayshan
Copy link

rayshan commented Jun 27, 2018

@arunoda thanks I tried airbnb-js-shims and it fixed both IE 11 and SEO issues. Payload cost is quite high though.

@thangngoc89 tried polyfill.io v2, did not work for me.

@thangngoc89
Copy link
Contributor

@rayshan I really hate it when people say "did not work for me". What do you mean by it's not working? what when wrong, ...

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants