Skip to content

Update workbox plugin to 5.1.2 resolving ServiceWorker quota exceeded errors #8821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jflayhart opened this issue Apr 11, 2020 · 1 comment

Comments

@jflayhart
Copy link

jflayhart commented Apr 11, 2020

Is your proposal related to a problem?

Currently our e-commerce site is experiencing millions of ServiceWorker DOMException: QuotaExceededError errors (we're not the only ones), which almost blowing through our monthly Rollbar limit 😬. I did some brief research and found that Google is aware of this issue and recommends purgeOnQuotaError to potentially fix most of these runtime quota issues.

I could be mistaken, but looks as if CRA is using workbox 4.3.1, and this purgeOnQuotaError was added in 5.0.0 as default enabled.

Since CRA follows best practices, I highly suggest we update Workbox plugin ASAP so we can be on par with Google's best practices for handling ServiceWorkers.

Thanks and love this app!

Describe the solution you'd like

Update workbox-webpack-plugin to 5.1.2

Describe alternatives you've considered

None possible without ejecting.

@tonix-tuft
Copy link

It also seems that workbox-webpack-plugin at version 4.3.1 uses a deprecated version of core-js:

host:package user$ npm ls core-js
└─┬ [email protected]
  ├─┬ [email protected]
  │ └── [email protected] 
  └─┬ [email protected]
    └─┬ [email protected]
      └─┬ [email protected]
        └─┬ [email protected]
          └─┬ [email protected]
            └── [email protected]  <--- Deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants