From 32c4285869a9c6b1accb6800659775c76f110ba9 Mon Sep 17 00:00:00 2001 From: Peter Bengtsson Date: Thu, 4 Oct 2018 21:07:55 -0400 Subject: [PATCH 1/2] avoid TypeError on when registering service workers without config Fixes #5299 --- packages/react-scripts/template/src/serviceWorker.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/template/src/serviceWorker.js b/packages/react-scripts/template/src/serviceWorker.js index 8859a0c6b20..a0153cb4c47 100644 --- a/packages/react-scripts/template/src/serviceWorker.js +++ b/packages/react-scripts/template/src/serviceWorker.js @@ -78,7 +78,7 @@ function registerValidSW(swUrl, config) { console.log('Content is cached for offline use.'); // Execute callback - if (config.onSuccess) { + if (config && config.onSuccess) { config.onSuccess(registration); } } From d600d8c31724ef6f150ed9faf1d0eb0d28ee77e5 Mon Sep 17 00:00:00 2001 From: Peter Bengtsson Date: Thu, 4 Oct 2018 21:10:41 -0400 Subject: [PATCH 2/2] same before config.onUpdate --- packages/react-scripts/template/src/serviceWorker.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/template/src/serviceWorker.js b/packages/react-scripts/template/src/serviceWorker.js index a0153cb4c47..46c98a44037 100644 --- a/packages/react-scripts/template/src/serviceWorker.js +++ b/packages/react-scripts/template/src/serviceWorker.js @@ -68,7 +68,7 @@ function registerValidSW(swUrl, config) { console.log('New content is available; please refresh.'); // Execute callback - if (config.onUpdate) { + if (config && config.onUpdate) { config.onUpdate(registration); } } else {