From 28102b7c753f3a3dddb5840712adbccb447c5852 Mon Sep 17 00:00:00 2001 From: endiliey Date: Sun, 31 Mar 2019 14:16:12 +0800 Subject: [PATCH 1/2] fix: terser-webpack-plugin hanging on WSL --- packages/react-scripts/config/webpack.config.js | 5 ++++- packages/react-scripts/package.json | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/react-scripts/config/webpack.config.js b/packages/react-scripts/config/webpack.config.js index c569868fdfa..c03e746fba2 100644 --- a/packages/react-scripts/config/webpack.config.js +++ b/packages/react-scripts/config/webpack.config.js @@ -9,6 +9,7 @@ 'use strict'; const fs = require('fs'); +const isWsl = require('is-wsl'); const path = require('path'); const webpack = require('webpack'); const resolve = require('resolve'); @@ -220,7 +221,9 @@ module.exports = function(webpackEnv) { }, // Use multi-process parallel running to improve the build speed // Default number of concurrent runs: os.cpus().length - 1 - parallel: true, + // Disabled on WSL (Windows Subsystem for Linux) due to an issue with Terser : + // https://github.com/webpack-contrib/terser-webpack-plugin/issues/21 + parallel: !isWsl, // Enable file caching cache: true, sourceMap: shouldUseSourceMap, diff --git a/packages/react-scripts/package.json b/packages/react-scripts/package.json index 0d480c87a80..59cef22af05 100644 --- a/packages/react-scripts/package.json +++ b/packages/react-scripts/package.json @@ -50,6 +50,7 @@ "fs-extra": "7.0.1", "html-webpack-plugin": "4.0.0-beta.5", "identity-obj-proxy": "3.0.0", + "is-wsl": "^1.1.0", "jest": "24.5.0", "jest-resolve": "24.5.0", "jest-watch-typeahead": "^0.2.1", From 21b7235c2e4f568327901fc9fd4e7283d73a51b5 Mon Sep 17 00:00:00 2001 From: endiliey Date: Sun, 31 Mar 2019 14:21:39 +0800 Subject: [PATCH 2/2] nits --- packages/react-scripts/config/webpack.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/config/webpack.config.js b/packages/react-scripts/config/webpack.config.js index c03e746fba2..36bf6118ae9 100644 --- a/packages/react-scripts/config/webpack.config.js +++ b/packages/react-scripts/config/webpack.config.js @@ -221,7 +221,7 @@ module.exports = function(webpackEnv) { }, // Use multi-process parallel running to improve the build speed // Default number of concurrent runs: os.cpus().length - 1 - // Disabled on WSL (Windows Subsystem for Linux) due to an issue with Terser : + // Disabled on WSL (Windows Subsystem for Linux) due to an issue with Terser // https://github.com/webpack-contrib/terser-webpack-plugin/issues/21 parallel: !isWsl, // Enable file caching