Make useRealTimers play well with timers: fake#3858
Merged
boujeepossum merged 1 commit intojestjs:masterfrom Jun 21, 2017
Merged
Make useRealTimers play well with timers: fake#3858boujeepossum merged 1 commit intojestjs:masterfrom
boujeepossum merged 1 commit intojestjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3858 +/- ##
==========================================
- Coverage 57.63% 57.62% -0.02%
==========================================
Files 194 194
Lines 6782 6784 +2
Branches 6 6
==========================================
Hits 3909 3909
- Misses 2870 2872 +2
Partials 3 3
Continue to review full report at Codecov.
|
rogeliog
approved these changes
Jun 20, 2017
Contributor
|
Does it also fix #3814? |
Contributor
Author
|
Haven't tried, but it seems like a node 7.4 issue. It works on every other version |
boujeepossum
approved these changes
Jun 21, 2017
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We unnecessarily call
useFakeTimerson everybeforeEach, even though it's only needed when combined withresetMocks.Fixes #3815
Test plan
Added an integration test.