Unified 'no tests found' message for non-verbose MPR#4354
Merged
cpojer merged 1 commit intojestjs:masterfrom Aug 25, 2017
Merged
Unified 'no tests found' message for non-verbose MPR#4354cpojer merged 1 commit intojestjs:masterfrom
cpojer merged 1 commit intojestjs:masterfrom
Conversation
boujeepossum
suggested changes
Aug 25, 2017
Contributor
boujeepossum
left a comment
boujeepossum
left a comment
There was a problem hiding this comment.
this is great!
thanks for adding the test too!
just refactor the message generation function and i think it's good to go!
packages/jest-cli/src/run_jest.js
Outdated
| const statsMessage = Object.keys(stats) | ||
| .map(key => { | ||
| if (key === 'roots' && config.roots.length === 1) { | ||
| if (globalConfig.verbose) { |
Contributor
There was a problem hiding this comment.
this whole function is getting pretty massive!
do you mind extracting it into a separate module get_no_test_found_message.js and splitting up a little?
something like:
// ...
const getNoTestsFoundMessage = (testRunData, globalConfig) => {
if (globalConfig.onlyChanged) {
return getNoTestFoundRelatedToChangedFiles(globalConfig);
}
return globalConfig.verbose
? getNoTestFoundVerbose(globalConfig, testRunData)
: getNoTestFound(globalConfig, testRunData);
}
module.exports = getNoTestsFoundMessage;
Contributor
Author
There was a problem hiding this comment.
Sure thing! Commit amended.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unified 'No test found' message for non-verbose MPR
Will now look like:
Resolves #4324
Test plan