Print errors after test structure in verbose mode#4504
Conversation
acamposruiz
force-pushed
the
issues/4264-print-errors-after-test
branch
from
0d5b5ee to
cddaa32
Compare
acamposruiz
force-pushed
the
issues/4264-print-errors-after-test
branch
from
cddaa32 to
90ecc08
Compare
boujeepossum
left a comment
boujeepossum
left a comment
There was a problem hiding this comment.
it looks good!
yeah, unfortunately we have this weird subclassing that i've been trying to kill for a long time and it makes changes like this to involve more things than they should :(
| }); | ||
|
|
||
| describe('.hasAssertions()', () => { | ||
| skipOnWindows.suite(); |
There was a problem hiding this comment.
what happened with this test? was there a "newline" issue?
There was a problem hiding this comment.
This test failed on window build into the 'continuous-integration/appveyor/pr — AppVeyor build failed' task without any reason about the code changed in my PR. So I used 'skipOnWindows.suite()' as many other cases where is used this approach too
|
You are right @aaronabramov , so have you thought about to take away this subclass?, I could create a new issue about this if you agree |
* Issue 4264: print errors after test structure in verbose mode * Fix lint (jestjs#4504)) * Skip test on windows
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
4 participants
Summary
This is a fix for this issue #4264
When running a single test that has many test cases the error messages are printed before the list of failing/passing tests which makes us to scroll up every time just to see the error message.
This Pull Request change the behavior of print error messages to put them after the list of tests
So the behavior is going to switch from the actual:
to this: