Simplify highlight for leading and trailing spaces in jest-diff#4553
Merged
cpojer merged 1 commit intojestjs:masterfrom Sep 28, 2017
Merged
Simplify highlight for leading and trailing spaces in jest-diff#4553cpojer merged 1 commit intojestjs:masterfrom
cpojer merged 1 commit intojestjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4553 +/- ##
==========================================
- Coverage 56.04% 56.01% -0.03%
==========================================
Files 185 185
Lines 6268 6264 -4
Branches 3 3
==========================================
- Hits 3513 3509 -4
Misses 2754 2754
Partials 1 1
Continue to review full report at Codecov.
|
Member
|
super awesome. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inversefor removed, added, in-changed lines.bgYellowfor unchanged lines which didn’t have highlight. The dim stack trace and gray lines caused a perceptual conflict instead of a contrast. Also as Scott said, gray was not light enough. I think yellow looks better on Windows. It looks like pollen on the following illustrations from MacOS Terminal. Also better not to churn snapshots of diffs.Removed lines are bgGreen at left and inverse of green at right, that is the same:
Added lines are bgRed at left and inverse of red at right, that is the same:
Indentation-changed lines are bgCyan at left and inverse of cyan at right, that is the same:
Unchanged lines are unhighlighted at left and bgYellow at right:
Thank y’all for reviewing incremental improvements even when urgent problems need solutions.
Next: similar change in
jest-matcher-utilsbut a few things puzzled me inexpectTest plan
Updated 4 snapshot in 1 test suite (renamed one of them)
P.S. Give my thanks to the Yarn team for improved links so previous PR passed AppVeyor CI