[jest-docblock] remove leading newlines from parseWithComments().comm…#4610
Merged
cpojer merged 1 commit intojestjs:masterfrom Oct 6, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4610 +/- ##
=======================================
Coverage 56.17% 56.17%
=======================================
Files 194 194
Lines 6544 6544
Branches 3 3
=======================================
Hits 3676 3676
Misses 2867 2867
Partials 1 1
Continue to review full report at Codecov.
|
Contributor
|
LGTM. My previous PR was to ensure we don't trim space characters, but removing newlines from the start and the end sounds good. |
azz
approved these changes
Oct 6, 2017
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While working on
--prependPragmaoption for prettier (prettier/prettier#2865), I noticed that jest-docblock is keeping around more leading newlines than would be expected in thecommentsresult ofparseWithComments().Example:
Current result of
parseWithComments().comments:Expected:
cc @azz