Fix errors when identity-obj-proxy mocks CSS Modules#4935
Merged
cpojer merged 2 commits intojestjs:masterfrom Nov 22, 2017
Merged
Fix errors when identity-obj-proxy mocks CSS Modules#4935cpojer merged 2 commits intojestjs:masterfrom
cpojer merged 2 commits intojestjs:masterfrom
Conversation
thymikee
approved these changes
Nov 22, 2017
Codecov Report
@@ Coverage Diff @@
## master #4935 +/- ##
==========================================
+ Coverage 60.26% 60.27% +0.01%
==========================================
Files 198 198
Lines 6593 6595 +2
Branches 3 3
==========================================
+ Hits 3973 3975 +2
Misses 2620 2620
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4580 and #4922
Because the mock identity object for CSS Modules returns the key as the value for any key:
trueavoids false positive inImmutableplugintestmethodval.constructor === 'function'avoids undefined as name of objectSee Mocking CSS Modules
Test plan
Added 2 tests which failed before changes to code, and then fixed them to fail for right reason :)