fix: get builtin modules from node core#5411
Merged
cpojer merged 1 commit intojestjs:masterfrom Jan 28, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5411 +/- ##
==========================================
- Coverage 62.26% 61.36% -0.91%
==========================================
Files 205 205
Lines 6925 6926 +1
Branches 4 3 -1
==========================================
- Hits 4312 4250 -62
- Misses 2612 2675 +63
Partials 1 1
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We don't currently get the list of builtins from node core, as we use the wrong API. See https://nodejs.org/api/modules.html#modules_module_builtinmodules
Test plan
Tested using
console.loglocally on node 9.4.0 that the list exists.