Don't skip configured matchers for exact file names#5582
Merged
cpojer merged 3 commits intojestjs:masterfrom Feb 16, 2018
Merged
Don't skip configured matchers for exact file names#5582cpojer merged 3 commits intojestjs:masterfrom
cpojer merged 3 commits intojestjs:masterfrom
Conversation
59dfabd to
8a109bf
Compare
Codecov Report
@@ Coverage Diff @@
## master #5582 +/- ##
==========================================
+ Coverage 60.63% 60.73% +0.09%
==========================================
Files 213 213
Lines 7311 7299 -12
Branches 3 3
==========================================
Hits 4433 4433
+ Misses 2877 2865 -12
Partials 1 1
Continue to review full report at Codecov.
|
Member
|
CI is unhappy |
Member
Author
|
Thanks @cpojer, fixed |
Member
|
Thanks for doing this! |
This was referenced Feb 20, 2018
This was referenced Mar 1, 2018
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR partially reverts #3882 so that we don't skip unmatched test paths from CLI
See previous:
Closes #5527
Test plan
I left the integrations tests that were there but reworded them and added a case
Without this change, the second case will fail