Conversation
| const {pluralize} = require('./reporters/utils'); | ||
| const {KEYS, ARROW} = require('./constants'); | ||
| const {ARROW} = require('./constants'); | ||
| import {KEYS} from 'jest-watch'; |
There was a problem hiding this comment.
Move import above consts
There was a problem hiding this comment.
wait, why are these requires? Didn't even notice
| "dependencies": { | ||
| "ansi-escapes": "^3.0.0", | ||
| "chalk": "^2.0.1", | ||
| "string-length": "^2.0.0" |
There was a problem hiding this comment.
Please make sure these are all deps jest-watch use
There was a problem hiding this comment.
I copied jest-cli and removed unused stuff, so it should be enough
There was a problem hiding this comment.
haven't checked if I can remove anything from jest-cli, though, lemme do that
EDIT: All 3 still used in cli
rogeliog
left a comment
rogeliog
left a comment
There was a problem hiding this comment.
Looks good, I'm just curious about what the responsibilities of jest-watch are going to be?
- Should this eventually evolve into a standalone "watch" package that can watch a filesystem and execute stuff against it and react to fs events? Or should it mainly be a place to make the initial plugins easier to develop?
This I think. So maybe the name is too generic? We already have |
Codecov Report
@@ Coverage Diff @@
## master #6318 +/- ##
==========================================
+ Coverage 63.65% 63.87% +0.22%
==========================================
Files 227 228 +1
Lines 8637 8698 +61
Branches 3 3
==========================================
+ Hits 5498 5556 +58
- Misses 3138 3141 +3
Partials 1 1
Continue to review full report at Codecov.
|
ghost
mentioned this pull request
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
6 participants
Summary
This splits out the parts needed to make watch plugins out of
jest-cliinto a new package calledjest-watch. I'm quite unfamiliar with watch mode, so I might have missed something, or included something which doesn't have to moveTest plan
All existing tests should pass.