Skip to content

Commit e76d664

Browse files
jbeshaymeta-codesync[bot]
authored andcommitted
HalfClosedLocalToClosed: give ACK and stream distinct PNs
Summary: The ACK used pre-increment and the stream packet used post-increment, so both ended up with the same packet number. D104911111 drops duplicates per RFC 9000 12.3, so the stream frame is no longer processed and readAvailable never fires. Use pre-increment for the stream packet, matching the convention used by the other ACK + stream pairs in this file. ___ overriding_review_checks_triggers_an_audit_and_retroactive_review Oncall Short Name: traffic_protocols landed-with-radar-review Differential Revision: D105880715 fbshipit-source-id: 69efdacaeda01db950ce2fc809a225142070a760
1 parent 1076e98 commit e76d664

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

quic/fizz/client/test/QuicClientTransportTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4855,7 +4855,7 @@ TEST_F(QuicClientTransportAfterStartTest, HalfClosedLocalToClosed) {
48554855
auto packet = packetToBuf(createStreamPacket(
48564856
*serverChosenConnId /* src */,
48574857
*originalConnId /* dest */,
4858-
appDataPacketNum++,
4858+
++appDataPacketNum,
48594859
streamId,
48604860
*data,
48614861
0 /* cipherOverhead */,

0 commit comments

Comments
 (0)