Change from size_t to uint64_t

Summary: Changing from size_t to uint64_t in WebTransport f/c related constructs for type safety/consistency.

Reviewed By: hanidamlaj

Differential Revision: D85719537

fbshipit-source-id: b0681cb50abd5075f75c2b33265713a73dbcdd9b

Author: Joanna Jo

proxygen/lib/http/session/HQSession.h

@@ -32,6 +32,7 @@
 #include <proxygen/lib/http/session/QuicProtocolInfo.h>
 #include <proxygen/lib/http/session/ServerPushLifecycle.h>
 #include <proxygen/lib/utils/ConditionalGate.h>
+#include <quic/QuicConstants.h>
 #include <quic/api/QuicSocket.h>
 #include <quic/common/BufUtil.h>
 #include <quic/common/events/FollyQuicEventBase.h>
@@ -1845,7 +1846,7 @@ class HQSession
     folly::Expected<folly::Unit, WebTransport::ErrorCode> sendDatagram(
         std::unique_ptr<folly::IOBuf> datagram) override;
 
-    size_t getWTInitialSendWindow() const override {
+    uint64_t getWTInitialSendWindow() const override {
       return session_.wtInitialSendWindow_;
     }
 
@@ -2005,10 +2006,10 @@ class HQSession
       {SettingsId::MAX_HEADER_LIST_SIZE, hq::kDefaultEgressMaxHeaderListSize},
       {SettingsId::_HQ_QPACK_BLOCKED_STREAMS,
        hq::kDefaultEgressQpackBlockedStream},
-      {SettingsId::WT_INITIAL_MAX_DATA, std::numeric_limits<size_t>::max()},
+      {SettingsId::WT_INITIAL_MAX_DATA, quic::kMaxVarInt},
   };
   HTTPSettings ingressSettings_;
-  size_t wtInitialSendWindow_{std::numeric_limits<size_t>::max()};
+  uint64_t wtInitialSendWindow_{quic::kMaxVarInt};
   // Maximum Stream/Push ID that we are allowed to open, from GOAWAY
   quic::StreamId peerMinUnseenId_{hq::kMaxClientBidiStreamId};
   uint64_t minUnseenIncomingPushId_{0};

proxygen/lib/http/webtransport/WebTransportImpl.h

@@ -11,6 +11,7 @@
 #include <proxygen/lib/http/codec/HTTPCodec.h>
 #include <proxygen/lib/http/webtransport/FlowController.h>
 #include <proxygen/lib/http/webtransport/WebTransport.h>
+#include <quic/QuicConstants.h>
 
 namespace {
 constexpr uint64_t kDefaultWTReceiveWindow = 1'048'576;
@@ -94,8 +95,8 @@ class WebTransportImpl : public WebTransport {
 
     virtual bool usesEncodedApplicationErrorCodes() = 0;
 
-    virtual size_t getWTInitialSendWindow() const {
-      return std::numeric_limits<size_t>::max();
+    virtual uint64_t getWTInitialSendWindow() const {
+      return quic::kMaxVarInt;
     }
   };
 
@@ -341,13 +342,13 @@ class WebTransportImpl : public WebTransport {
   WTIngressStreamMap wtIngressStreams_;
   // Initialize flow controllers with max value for backward compatibility and
   // to ensure no functional change yet.
-  FlowController sendFlowController_{std::numeric_limits<size_t>::max()};
-  FlowController recvFlowController_{std::numeric_limits<size_t>::max()};
+  FlowController sendFlowController_{quic::kMaxVarInt};
+  FlowController recvFlowController_{quic::kMaxVarInt};
   folly::Optional<uint32_t> sessionCloseError_;
   uint64_t bytesRead_{};
 
   struct StreamFlowControl {
-    uint64_t maxStreamID{std::numeric_limits<uint64_t>::max()};
+    uint64_t maxStreamID{quic::kMaxVarInt};
     uint64_t numClosedStreams{};
     uint64_t targetConcurrentStreams{kDefaultTargetConcurrentStreams};
   };
@@ -403,9 +404,8 @@ class WebTransportImpl : public WebTransport {
     return (id & 0b10) == 0;
   }
 
-  void setFlowControlLimits(
-      size_t sendWindow = std::numeric_limits<size_t>::max(),
-      size_t recvWindow = std::numeric_limits<size_t>::max()) {
+  void setFlowControlLimits(uint64_t sendWindow = quic::kMaxVarInt,
+                            uint64_t recvWindow = quic::kMaxVarInt) {
     sendFlowController_ = FlowController(sendWindow);
     recvFlowController_ = FlowController(recvWindow);
   }