Clean up dead_code warnings.

Summary: Over time some dead code warnings have accumulated throughout the codebase that are no longer valid. Had claude do a search and remove these.

Reviewed By: stroxler

Differential Revision: D96519259

fbshipit-source-id: 39e5f77e96b96d02a3a4db54f73f90c19d737567

Author: jvansch1

crates/pyrefly_bundled/src/lib.rs

@@ -118,7 +118,6 @@ pub fn bundled_typeshed() -> anyhow::Result<SmallMap<PathBuf, String>> {
     extract_pyi_files_from_archive(PathFilter::Stdlib)
 }
 
-#[allow(dead_code)]
 pub fn bundled_third_party_stubs() -> anyhow::Result<SmallMap<PathBuf, String>> {
     extract_pyi_files_from_archive(PathFilter::ThirdPartyTypeshedStubs)
 }

crates/pyrefly_python/src/module_name.rs

@@ -250,7 +250,6 @@ impl ModuleName {
         Self::from_str("pydantic.main")
     }
 
-    #[allow(dead_code)]
     pub fn pydantic_settings() -> Self {
         Self::from_str("pydantic_settings.main")
     }
@@ -259,7 +258,6 @@ impl ModuleName {
         Self::from_str("pydantic.root_model")
     }
 
-    #[allow(dead_code)]
     pub fn pydantic_dataclasses() -> Self {
         Self::from_str("pydantic.dataclasses")
     }

crates/pyrefly_types/src/type_var.rs

@@ -97,7 +97,6 @@ pub enum Variance {
     Covariant,
     Contravariant,
     Invariant,
-    #[allow(dead_code)]
     Bivariant,
 }
 

pyrefly/lib/alt/answers.rs

@@ -294,7 +294,6 @@ impl Solutions {
         &self.metadata
     }
 
-    #[allow(dead_code)] // Used in tests.
     pub fn get<K: Exported>(&self, key: &K) -> &Arc<<K as Keyed>::Answer>
     where
         SolutionsTable: TableKeyed<K, Value = SolutionsEntry<K>>,

pyrefly/lib/lsp/non_wasm/server.rs

@@ -450,7 +450,6 @@ pub struct Connection {
 /// without requiring interior mutability — stdin is only ever read from one
 /// thread.
 pub enum MessageReader {
-    #[cfg_attr(not(test), allow(dead_code))]
     Channel(Receiver<Message>),
     Stdio(BufReader<Stdin>),
 }

pyrefly/lib/report/pysa/ast_visitor.rs

@@ -42,7 +42,6 @@ pub enum Scope {
         decorated_function: DecoratedFunction,
     },
     ExportedClass {
-        #[allow(dead_code)]
         class_id: ClassId,
         #[allow(dead_code)]
         class_name: Name,
@@ -81,22 +80,19 @@ pub enum ExportFunctionDecorators {
     InDecoratedFunction,
     InParentScope,
     InDecoratedTarget,
-    #[allow(dead_code)]
     Ignore,
 }
 
 pub enum ExportClassDecorators {
     #[allow(dead_code)]
     InDecoratedClassTopLevel,
     InParentScope,
-    #[allow(dead_code)]
     Ignore,
 }
 
 pub enum ExportDefaultArguments {
     InFunction,
     InParentScope,
-    #[allow(dead_code)]
     Ignore,
 }
 

pyrefly/lib/report/pysa/types.rs

@@ -27,7 +27,6 @@ use crate::types::display::TypeDisplayContext;
 
 /// Modifier that was stripped from a type to extract the underlying class.
 #[derive(Debug, Clone, Copy, Serialize, PartialEq, Eq, Hash, PartialOrd, Ord)]
-#[allow(dead_code)]
 pub enum TypeModifier {
     Optional,               // Optional[T]
     Coroutine,              // Coroutine[<...>]

pyrefly/lib/state/subscriber.rs

@@ -75,14 +75,12 @@ impl Subscriber for TestSubscriber {
 }
 
 impl TestSubscriber {
-    #[allow(dead_code)] // Only in test code
     pub fn new() -> Self {
         Self::default()
     }
 
     /// For each handle, return a pair of (the number of times each handle started, the final load state).
     /// Panics if any handle was started but not finished.
-    #[allow(dead_code)] // Only in test code
     pub fn finish(self) -> SmallMap<Handle, (usize, Option<Arc<Load>>)> {
         mem::take(&mut *self.0.lock())
     }

pyrefly/lib/test/lsp/lsp_interaction/object_model.rs

@@ -657,7 +657,6 @@ impl TestClient {
     }
 
     /// Send a file deletion event notification
-    #[allow(dead_code)]
     pub fn file_deleted(&self, file: &str) {
         let path = self.get_root_or_panic().join(file);
         self.send_notification::<DidChangeWatchedFiles>(json!({

pyrefly/lib/tsp/validation.rs

@@ -14,9 +14,6 @@
 //! - Canonical TSP error construction (invalid params, internal, etc.)
 //! - Response dispatch (success or error, routed through `TspInterface`)
 
-// Helpers are public API for upcoming message handlers; suppress until first use.
-#![allow(dead_code)]
-
 use lsp_server::ErrorCode;
 use lsp_server::RequestId;
 use lsp_server::ResponseError;