Skip to content

Commit 74161e2

Browse files
wolfibDevtools-frontend LUCI CQ
authored andcommitted
Remove tabindex from list in SelectWorkspaceDialog
Keyboard navigation for the list items themselves has been improved. This CL makes the list itself not focusable via tab, since up/down- cursor would scroll the whole list which is confusing, since up/down- cursor already scrolls the list and selects the prev./next item when an item is in focus. Bug: 410714934 Change-Id: I559eb656205198ca31d4a5faaaf74a1df093892e Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6459607 Commit-Queue: Wolfgang Beyer <[email protected]> Reviewed-by: Samiya Caur <[email protected]>
1 parent aa54081 commit 74161e2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

front_end/panels/ai_assistance/SelectWorkspaceDialog.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ export class SelectWorkspaceDialog extends UI.Widget.VBox {
119119
` : nothing}
120120
</div>
121121
${hasFolders ? html`
122-
<ul role="listbox" aria-label=${lockedString(UIStringsNotTranslate.selectFolder)} tabindex="0"
122+
<ul role="listbox" aria-label=${lockedString(UIStringsNotTranslate.selectFolder)}
123123
aria-activedescendant=${input.folders.length > 0 ? `option-${input.selectedIndex}` : ''}>
124124
${input.folders.map((folder, index) => {
125125
const optionId = `option-${index}`;

0 commit comments

Comments
 (0)