Skip to content

Commit 00a942c

Browse files
ajpaulingallskelset
authored andcommitted
Update the cached dimensions when orientation changes (#30324)
Summary: Currently the dimensions are created once, and then cached. This change will reload the dimensions when the device orientation changes to insure that dimension update events follow orientation changed events. this should help address the following issues, that I know of: #29105 #29451 #29323 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Android] [Fixed] - Dimension update events are now properly sent following orientation change Pull Request resolved: #30324 Test Plan: Open up RNTester app. Select the Dimensions API list item. Rotate the device and verify that the dimensions are correct based on orientation. Reviewed By: fkgozali Differential Revision: D24874733 Pulled By: ejanzer fbshipit-source-id: 867681ecb009d368a2ae7b67d94d6355e67dea7b
1 parent ec5090a commit 00a942c

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -705,6 +705,7 @@ private void checkForDeviceOrientationChanges() {
705705
return;
706706
}
707707
mDeviceRotation = rotation;
708+
DisplayMetricsHolder.initDisplayMetrics(getContext().getApplicationContext());
708709
emitOrientationChanged(rotation);
709710
}
710711

0 commit comments

Comments
 (0)