Skip to content

Commit 13177b3

Browse files
okwasniewskifacebook-github-bot
authored andcommitted
feat: warn about jsc moving to a separate repo (#49692)
Summary: > [!NOTE] > This PR is part of JavaScriptCore Extraction to this repository: https://github.com/react-native-community/javascriptcore This PR warns about JavaScriptCore being moved in the postinstall phase: ![CleanShot 2025-02-26 at 13 35 54@2x](https://github.com/user-attachments/assets/f392f7a3-fb8b-4089-9375-2d88ba4cb60b) as well as in the build logs: ![CleanShot 2025-02-26 at 13 35 45@2x](https://github.com/user-attachments/assets/481e44f2-c30e-43f2-8cbc-5006959a42fc) ## Changelog: [IOS] [ADDED] - Inform users about JSC being moved to a different repo Pull Request resolved: #49692 Test Plan: CI Grene Reviewed By: huntie Differential Revision: D70321201 Pulled By: cipolleschi fbshipit-source-id: 1a97f3bceb57079f0e63848745c1a973b6dd614d
1 parent ed10664 commit 13177b3

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

packages/react-native/scripts/react_native_pods.rb

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,6 +372,17 @@ def rct_cxx_language_standard()
372372
return Helpers::Constants.cxx_language_standard
373373
end
374374

375+
def print_jsc_removal_message()
376+
puts ''
377+
puts '=============== JavaScriptCore is being moved ==============='.yellow
378+
puts 'JavaScriptCore has been extracted from react-native core'.yellow
379+
puts 'and will be removed in a future release. It can now be'.yellow
380+
puts 'installed from `@react-native-community/javascriptcore`'.yellow
381+
puts 'See: https://github.com/react-native-community/javascriptcore'.yellow
382+
puts '============================================================='.yellow
383+
puts ''
384+
end
385+
375386
def print_cocoapods_deprecation_message()
376387
if ENV["RCT_IGNORE_PODS_DEPRECATION"] == "1"
377388
return
@@ -408,7 +419,6 @@ def react_native_post_install(
408419

409420
ReactNativePodsUtils.apply_mac_catalyst_patches(installer) if mac_catalyst_enabled
410421

411-
fabric_enabled = ENV['RCT_FABRIC_ENABLED'] == '1'
412422
hermes_enabled = ENV['USE_HERMES'] == '1'
413423
privacy_file_aggregation_enabled = ENV['RCT_AGGREGATE_PRIVACY_FILES'] == '1'
414424

@@ -441,6 +451,10 @@ def react_native_post_install(
441451
NewArchitectureHelper.set_clang_cxx_language_standard_if_needed(installer)
442452
NewArchitectureHelper.modify_flags_for_new_architecture(installer, NewArchitectureHelper.new_arch_enabled)
443453

454+
if ENV['USE_HERMES'] == '0' && ENV['USE_THIRD_PARTY_JSC'] != '1'
455+
print_jsc_removal_message()
456+
end
457+
444458
print_cocoapods_deprecation_message
445459
Pod::UI.puts "Pod install took #{Time.now.to_i - $START_TIME} [s] to run".green
446460
end

0 commit comments

Comments
 (0)