Skip to content

Commit 1477436

Browse files
javachepull[bot]
authored andcommitted
Fix view recycling incorrectly resetting transform (#39306)
Summary: Pull Request resolved: #39306 This broke on Android platforms where `ReactFeatureFlags.enableViewRecycling` is enabled, as `setTransform` no longer directly mutates the transform properties, but instead goes through `setTransformProperty` Changelog: [Internal] Reviewed By: rshest Differential Revision: D49008194 fbshipit-source-id: 7e5543b8ce79caaaf380f20010bdde69f6e212b1
1 parent 502a20f commit 1477436

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,9 @@ protected T prepareToRecycleView(@NonNull ThemedReactContext reactContext, T vie
7979
// setScaleX
8080
// setScaleY
8181
// setCameraDistance
82-
setTransform(view, null);
82+
setTransformProperty(view, null, null);
8383

84-
// RenderNode params not covered by setTransform above
84+
// RenderNode params not covered by setTransformProperty above
8585
view.resetPivot();
8686
view.setTop(0);
8787
view.setBottom(0);
@@ -94,6 +94,7 @@ protected T prepareToRecycleView(@NonNull ThemedReactContext reactContext, T vie
9494
view.setTag(R.id.transform_origin, null);
9595
view.setTag(R.id.invalidate_transform, null);
9696
view.removeOnLayoutChangeListener(this);
97+
9798
// setShadowColor
9899
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
99100
view.setOutlineAmbientShadowColor(Color.BLACK);

0 commit comments

Comments
 (0)