Skip to content

Commit 33ca020

Browse files
Zhi Zhoucipolleschi
authored andcommitted
fix: iOS crash occurring when navigating to a new app screen with a displaying modal (#45313)
Summary: Our app is using the react-native v0.74.2 with the `react-navigation` lib for screen navigation, we're facing an issue in the built iOS app that when we try to navigate to a new app screen with the `react-navigation`'s `reset` or `replace` method and meanwhile there's a react native modal displaying, then the iOS app always crashes. I saw there is already a relevant [PR](#38491) and discussion targeting this issue, but I still think it would be better if this kind of crash can be suppressed in the framework level, currently I guess it's common in the iOS apps based on react native. ## Changelog: [IOS] [FIXED] - app crash happening when navigate to a new app screen with a displaying modal Pull Request resolved: #45313 Test Plan: More issue details and the reproduction steps can be found in this [PR](#38491) :) Reviewed By: christophpurrer Differential Revision: D61537167 Pulled By: cipolleschi fbshipit-source-id: 3c0474d794b4216ebc073dd6558d2b6ae27492d2
1 parent ad2a59b commit 33ca020

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

packages/react-native/React/Views/RCTModalHostView.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ - (void)dismissModalViewController
119119
if (_isPresented) {
120120
[_delegate dismissModalHostView:self withViewController:_modalViewController animated:[self hasAnimationType]];
121121
_isPresented = NO;
122+
[self setVisible:NO];
122123
}
123124
}
124125

0 commit comments

Comments
 (0)