Skip to content

Commit 68d6ada

Browse files
riteshshukla04facebook-github-bot
authored andcommitted
Fixed borderBottomEndRadius on RTL (#51229)
Summary: Fixes #51193 ## Changelog: [ANDROID][FIXED] Wrong borderBottomEndRadius on RTL Pull Request resolved: #51229 Test Plan: Tested with Arabic (RTL) and English(LTR) English <img src="https://github.com/user-attachments/assets/5bd1eca9-194c-4d83-b75f-689bc13d827b" width=200> Arabic <img src="https://github.com/user-attachments/assets/459320a0-6bb2-4585-97bb-bd4ded6ec399" width=200> Reviewed By: cortinico Differential Revision: D74709219 Pulled By: NickGerleman fbshipit-source-id: 885bb84d97d73324983d044fd2874a457b40f646
1 parent 7773976 commit 68d6ada

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/style/BorderRadiusStyle.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,11 @@ internal data class BorderRadiusStyle(
143143
CornerRadii(it, width, height)
144144
} ?: zeroRadii,
145145
bottomLeft =
146-
(endEnd ?: bottomStart ?: bottomRight ?: uniform)?.let {
146+
(endEnd ?: bottomEnd ?: bottomRight ?: uniform)?.let {
147147
CornerRadii(it, width, height)
148148
} ?: zeroRadii,
149149
bottomRight =
150-
(startEnd ?: bottomEnd ?: bottomLeft ?: uniform)?.let {
150+
(startEnd ?: bottomStart ?: bottomLeft ?: uniform)?.let {
151151
CornerRadii(it, width, height)
152152
} ?: zeroRadii,
153153
width = width,

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/BorderRadiusStyleTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,13 +95,13 @@ class BorderRadiusStyleTest {
9595
arrayOf(
9696
BorderRadiusProp.BORDER_RADIUS,
9797
BorderRadiusProp.BORDER_BOTTOM_RIGHT_RADIUS,
98-
BorderRadiusProp.BORDER_BOTTOM_START_RADIUS,
98+
BorderRadiusProp.BORDER_BOTTOM_END_RADIUS,
9999
BorderRadiusProp.BORDER_END_END_RADIUS),
100100
ComputedBorderRadiusProp.COMPUTED_BORDER_BOTTOM_RIGHT_RADIUS to
101101
arrayOf(
102102
BorderRadiusProp.BORDER_RADIUS,
103103
BorderRadiusProp.BORDER_BOTTOM_LEFT_RADIUS,
104-
BorderRadiusProp.BORDER_BOTTOM_END_RADIUS,
104+
BorderRadiusProp.BORDER_BOTTOM_START_RADIUS,
105105
BorderRadiusProp.BORDER_START_END_RADIUS),
106106
)
107107

0 commit comments

Comments
 (0)