Skip to content

Commit adb3bee

Browse files
cipolleschifabriziocucci
authored andcommitted
Have react-hermes and React-renderercss define modules (#50283)
Summary: Pull Request resolved: #50283 In OSS we have some libraries written in Swift, like Flashlist, that depends on these pods. However, if a pod is not configured to define modules, those pods cannot be imported by Swift. Therefore, the libraries above will failed to be installed in a project. This change adds the defines_modules directive to those pods and make the library work again. This fixes #50246 [Internal] - Make React-hermes and React-renderercss defines modules Reviewed By: fabriziocucci Differential Revision: D71892679 fbshipit-source-id: b03b65986fbdbe781b616f31dfb6bceb38b8b3b7
1 parent a42971a commit adb3bee

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

packages/react-native/ReactCommon/hermes/React-hermes.podspec

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ Pod::Spec.new do |s|
3838
s.compiler_flags = folly_compiler_flags + ' ' + boost_compiler_flags
3939
s.pod_target_xcconfig = {
4040
"HEADER_SEARCH_PATHS" => "\"${PODS_ROOT}/hermes-engine/destroot/include\" \"$(PODS_TARGET_SRCROOT)/..\" \"$(PODS_ROOT)/boost\" \"$(PODS_ROOT)/RCT-Folly\" \"$(PODS_ROOT)/DoubleConversion\" \"$(PODS_ROOT)/fmt/include\"",
41-
"CLANG_CXX_LANGUAGE_STANDARD" => rct_cxx_language_standard()
41+
"CLANG_CXX_LANGUAGE_STANDARD" => rct_cxx_language_standard(),
42+
"DEFINES_MODULE" => "YES",
4243
}
4344
s.header_dir = "reacthermes"
4445
s.dependency "React-cxxreact", version

packages/react-native/ReactCommon/react/renderer/css/React-renderercss.podspec

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,9 @@ Pod::Spec.new do |s|
3636
s.exclude_files = "tests"
3737
s.pod_target_xcconfig = {
3838
"CLANG_CXX_LANGUAGE_STANDARD" => rct_cxx_language_standard(),
39-
"HEADER_SEARCH_PATHS" => header_search_paths.join(' ')}
39+
"HEADER_SEARCH_PATHS" => header_search_paths.join(' '),
40+
"DEFINES_MODULE" => "YES",
41+
}
4042

4143
if ENV['USE_FRAMEWORKS']
4244
s.module_name = "React_renderercss"

packages/rn-tester/Podfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2072,7 +2072,7 @@ SPEC CHECKSUMS:
20722072
React-featureflags: e8b460883a5562ce85c934f248655a81d5e09f21
20732073
React-featureflagsnativemodule: 1e45e1fbd40365126d7f3031c28b9adc3bb5a9ab
20742074
React-graphics: 447cb78eeb5032559e52e108dfcaa617ddb4f8b2
2075-
React-hermes: b2c226849aead986fddb910095b8cbd6c021fd84
2075+
React-hermes: de7afc9a3c8f2f606b513e1117f744622b26e30f
20762076
React-idlecallbacksnativemodule: f1ffb0492bb917e60173d96f900ba606747f2640
20772077
React-ImageManager: 7516b2f25b0fdd0c2bacb1b9caf1c40ffa1164db
20782078
React-jserrorhandler: 597481e95cb4fbb8fece874feece6260e1bc1811
@@ -2105,7 +2105,7 @@ SPEC CHECKSUMS:
21052105
React-RCTText: 39b42fead378ad75d13098d2ea255babd926b362
21062106
React-RCTVibration: 879098fe9af91e6258cdae398c47e73e5276c281
21072107
React-rendererconsistency: a4d8b222d165650a4bff33cf50033e1adf9a87a3
2108-
React-renderercss: c7608edd7431dce92af0d474153e939543d96f15
2108+
React-renderercss: 9e2bccdc273677485ba16a59132799ab34276596
21092109
React-rendererdebug: 1265d77c2abab3fde1f1450cf165725069452608
21102110
React-rncore: 27f409047489a44511ad49e64fbc00b798455cbc
21112111
React-RuntimeApple: c945d4c1529ea33db3f51156d362cbff596e1715

0 commit comments

Comments
 (0)