Align ActivityIndicator with OSS types (#49519)

Summary:
Pull Request resolved: #49519

Changelog: [Internal]

Reviewed By: huntie

Differential Revision: D69661567

fbshipit-source-id: 35e3849eeea188f8bdfa0664c90d3d9e5328ef80

Author: j-piasecki

packages/react-native/Libraries/Components/ActivityIndicator/ActivityIndicator.js

@@ -26,17 +26,17 @@ const GRAY = '#999999';
 
 type IndicatorSize = number | 'small' | 'large';
 
-type IOSProps = $ReadOnly<{
+type ActivityIndicatorIOSProps = $ReadOnly<{
   /**
     Whether the indicator should hide when not animating.
 
     @platform ios
   */
   hidesWhenStopped?: ?boolean,
 }>;
-type Props = $ReadOnly<{
+export type ActivityIndicatorProps = $ReadOnly<{
   ...ViewProps,
-  ...IOSProps,
+  ...ActivityIndicatorIOSProps,
 
   /**
    	Whether to show the indicator (`true`) or hide it (`false`).
@@ -69,7 +69,7 @@ const ActivityIndicator = (
     size = 'small',
     style,
     ...restProps
-  }: Props,
+  }: ActivityIndicatorProps,
   forwardedRef?: any,
 ) => {
   let sizeStyle;
@@ -154,8 +154,8 @@ const ActivityIndicator = (
 */
 
 const ActivityIndicatorWithRef: component(
-  ref: React.RefSetter<HostComponent<empty>>,
-  ...props: Props
+  ref?: React.RefSetter<HostComponent<empty>>,
+  ...props: ActivityIndicatorProps
 ) = React.forwardRef(ActivityIndicator);
 ActivityIndicatorWithRef.displayName = 'ActivityIndicator';
 

packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap

@@ -1382,19 +1382,19 @@ declare export default typeof legacySendAccessibilityEvent;
 
 exports[`public API should not change unintentionally Libraries/Components/ActivityIndicator/ActivityIndicator.js 1`] = `
 "type IndicatorSize = number | \\"small\\" | \\"large\\";
-type IOSProps = $ReadOnly<{
+type ActivityIndicatorIOSProps = $ReadOnly<{
   hidesWhenStopped?: ?boolean,
 }>;
-type Props = $ReadOnly<{
+export type ActivityIndicatorProps = $ReadOnly<{
   ...ViewProps,
-  ...IOSProps,
+  ...ActivityIndicatorIOSProps,
   animating?: ?boolean,
   color?: ?ColorValue,
   size?: ?IndicatorSize,
 }>;
 declare const ActivityIndicatorWithRef: component(
-  ref: React.RefSetter<HostComponent<empty>>,
-  ...props: Props
+  ref?: React.RefSetter<HostComponent<empty>>,
+  ...props: ActivityIndicatorProps
 );
 declare export default typeof ActivityIndicatorWithRef;
 "

scripts/build/build-types/buildTypes.js

@@ -36,6 +36,7 @@ const ENTRY_POINTS = [
   'packages/react-native/Libraries/Blob/URL.js',
   'packages/react-native/Libraries/Blob/URLSearchParams.js',
   'packages/react-native/Libraries/Components/AccessibilityInfo/AccessibilityInfo.js',
+  'packages/react-native/Libraries/Components/ActivityIndicator/ActivityIndicator.js',
   'packages/react-native/Libraries/Components/Clipboard/Clipboard.js',
   'packages/react-native/Libraries/Components/LayoutConformance/LayoutConformance.js',
   'packages/react-native/Libraries/Components/ToastAndroid/ToastAndroid.js',