Skip to content

Commit 03297e0

Browse files
authored
[compiler] transform fire calls (#31796)
This is the diff with the meaningful changes. The approach is: 1. Collect fire callees and remove fire() calls, create a new binding for the useFire result 2. Update LoadLocals for captured callees to point to the useFire result 3. Update function context to reference useFire results 4. Insert useFire calls after getting to the component scope This approach aims to minimize the amount of new bindings we introduce for the function expressions to minimize bookkeeping for dependency arrays. We keep all of the LoadLocals leading up to function calls as they are and insert new instructions to load the originally captured function, call useFire, and store the result in a new promoted temporary. The lvalues that referenced the original callee are changed to point to the new useFire result. This is the minimal diff to implement the expected behavior (up to importing the useFire call, next diff) and further stacked diffs implement error handling. The rules for fire are: 1. If you use fire for a callee in the effect once you must use it for every time you call it in that effect 2. You can only use fire in a useEffect lambda/functions defined inside the useEffect lambda There is still more work to do here, like updating the effect dependency array and handling object methods -- --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31796). * #31811 * #31798 * #31797 * __->__ #31796
1 parent 99471c0 commit 03297e0

27 files changed

+1383
-0
lines changed

compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Pipeline.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ import {validateNoJSXInTryStatement} from '../Validation/ValidateNoJSXInTryState
9898
import {propagateScopeDependenciesHIR} from '../HIR/PropagateScopeDependenciesHIR';
9999
import {outlineJSX} from '../Optimization/OutlineJsx';
100100
import {optimizePropsMethodCalls} from '../Optimization/OptimizePropsMethodCalls';
101+
import {transformFire} from '../Transform';
101102

102103
export type CompilerPipelineValue =
103104
| {kind: 'ast'; name: string; value: CodegenFunction}
@@ -197,6 +198,11 @@ function runWithEnvironment(
197198
validateHooksUsage(hir);
198199
}
199200

201+
if (env.config.enableFire) {
202+
transformFire(hir);
203+
log({kind: 'hir', name: 'TransformFire', value: hir});
204+
}
205+
200206
if (env.config.validateNoCapitalizedCalls) {
201207
validateNoCapitalizedCalls(hir);
202208
}

0 commit comments

Comments
 (0)