Skip to content

Commit 1cfd332

Browse files
author
Brian Vaughn
authored
Shutdown DevTools Bridge synchronously when unmounting (#19180)
1 parent 5b98656 commit 1cfd332

File tree

1 file changed

+3
-2
lines changed
  • packages/react-devtools-shared/src/devtools/views

1 file changed

+3
-2
lines changed

packages/react-devtools-shared/src/devtools/views/DevTools.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import '@reach/menu-button/styles.css';
1313
import '@reach/tooltip/styles.css';
1414

1515
import * as React from 'react';
16-
import {useEffect, useMemo, useRef} from 'react';
16+
import {useEffect, useLayoutEffect, useMemo, useRef} from 'react';
1717
import Store from '../store';
1818
import {BridgeContext, ContextMenuContext, StoreContext} from './context';
1919
import Components from './Components/Components';
@@ -169,9 +169,10 @@ export default function DevTools({
169169
};
170170
}, [showTabBar]);
171171

172-
useEffect(() => {
172+
useLayoutEffect(() => {
173173
return () => {
174174
try {
175+
// Shut the Bridge down synchronously (during unmount).
175176
bridge.shutdown();
176177
} catch (error) {
177178
// Attempting to use a disconnected port.

0 commit comments

Comments
 (0)