Skip to content

Commit 32d7ecf

Browse files
vzaidmanvzaidman
committed
fix[react-devtools] remove native inspection button when it can't be used (#29779)
## Summary There's no native inspection available in any of the React-Native devtools: * **React DevTools in Fusebox** * **React DevTools standalone** Besides, **React DevTools Inline** can't really open the devtools and point to the native inspector because of lack of an API to do that. Only **React DevTools extension** can actually do that. That's why I've disabled it for the first 3 flavours of React DevTools mentioned above. ## How did you test this change? Still enabled on **React DevTools extension** <img width="1355" alt="Screenshot 2024-06-06 at 16 09 21" src="https://github.com/facebook/react/assets/5188459/a9b658a6-eafe-443c-9298-280bb9f4ed72"> Disabled on **React DevTools in Fusebox** <img width="1670" alt="Screenshot 2024-06-06 at 16 04 28" src="https://github.com/facebook/react/assets/5188459/a2ded76f-2aaf-47ce-b581-611494ca33bd"> Disabled on **React DevTools standalone** <img width="1268" alt="Screenshot 2024-06-06 at 16 15 08" src="https://github.com/facebook/react/assets/5188459/eb2f308d-32cb-43ea-921b-3503aa874d64"> Disabled on **React DevTools Inline** <img width="1206" alt="Screenshot 2024-06-06 at 16 09 26" src="https://github.com/facebook/react/assets/5188459/03da741a-66bf-4414-91f7-2f344c78a880"> DiffTrain build for commit 99da76f.
1 parent 59b1f85 commit 32d7ecf

File tree

14 files changed

+36
-36
lines changed

14 files changed

+36
-36
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.0.0-native-fb-704aeed022-20240605
1+
19.0.0-native-fb-99da76f23a-20240606

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<d112a309d22f8a4dc055a4e175817978>>
10+
* @generated SignedSource<<8ff0896135b7b18c20904b27e0db88a8>>
1111
*/
1212

1313
'use strict';
@@ -23580,7 +23580,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
2358023580
return root;
2358123581
}
2358223582

23583-
var ReactVersion = '19.0.0-native-fb-704aeed022-20240605';
23583+
var ReactVersion = '19.0.0-native-fb-99da76f23a-20240606';
2358423584

2358523585
/*
2358623586
* The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-prod.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<115011faaefd58115d16348c330f8f1b>>
10+
* @generated SignedSource<<dfd7547611fb05ceb70414ceebfd0e64>>
1111
*/
1212

1313
"use strict";
@@ -9336,7 +9336,7 @@ var devToolsConfig$jscomp$inline_1048 = {
93369336
throw Error("TestRenderer does not support findFiberByHostInstance()");
93379337
},
93389338
bundleType: 0,
9339-
version: "19.0.0-native-fb-704aeed022-20240605",
9339+
version: "19.0.0-native-fb-99da76f23a-20240606",
93409340
rendererPackageName: "react-test-renderer"
93419341
};
93429342
var internals$jscomp$inline_1235 = {
@@ -9367,7 +9367,7 @@ var internals$jscomp$inline_1235 = {
93679367
scheduleRoot: null,
93689368
setRefreshHandler: null,
93699369
getCurrentFiber: null,
9370-
reconcilerVersion: "19.0.0-native-fb-704aeed022-20240605"
9370+
reconcilerVersion: "19.0.0-native-fb-99da76f23a-20240606"
93719371
};
93729372
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
93739373
var hook$jscomp$inline_1236 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-profiling.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<1c7492b335b3cd1b33f7371893e59b44>>
10+
* @generated SignedSource<<85ef7c6c3e299bddaa219dd6a7ddb485>>
1111
*/
1212

1313
"use strict";
@@ -9958,7 +9958,7 @@ var devToolsConfig$jscomp$inline_1131 = {
99589958
throw Error("TestRenderer does not support findFiberByHostInstance()");
99599959
},
99609960
bundleType: 0,
9961-
version: "19.0.0-native-fb-704aeed022-20240605",
9961+
version: "19.0.0-native-fb-99da76f23a-20240606",
99629962
rendererPackageName: "react-test-renderer"
99639963
};
99649964
(function (internals) {
@@ -10002,7 +10002,7 @@ var devToolsConfig$jscomp$inline_1131 = {
1000210002
scheduleRoot: null,
1000310003
setRefreshHandler: null,
1000410004
getCurrentFiber: null,
10005-
reconcilerVersion: "19.0.0-native-fb-704aeed022-20240605"
10005+
reconcilerVersion: "19.0.0-native-fb-99da76f23a-20240606"
1000610006
});
1000710007
exports._Scheduler = Scheduler;
1000810008
exports.act = act;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<9992a07147563b590431e5a2612eef2f>>
10+
* @generated SignedSource<<049d661e8333442e2c93b0310afe90c8>>
1111
*/
1212

1313
'use strict';
@@ -24,7 +24,7 @@ if (
2424
}
2525
var dynamicFlagsUntyped = require('ReactNativeInternalFeatureFlags');
2626

27-
var ReactVersion = '19.0.0-native-fb-704aeed022-20240605';
27+
var ReactVersion = '19.0.0-native-fb-99da76f23a-20240606';
2828

2929
// Re-export dynamic flags from the internal module.
3030
var dynamicFlags = dynamicFlagsUntyped; // We destructure each value before re-exporting to avoid a dynamic look-up on

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<e3ef3b33335bb569b7a4d4e3de157648>>
10+
* @generated SignedSource<<7ecaa5f36e67e1c798758af01a9ca63a>>
1111
*/
1212

1313
"use strict";
@@ -604,4 +604,4 @@ exports.useSyncExternalStore = function (
604604
exports.useTransition = function () {
605605
return ReactSharedInternals.H.useTransition();
606606
};
607-
exports.version = "19.0.0-native-fb-704aeed022-20240605";
607+
exports.version = "19.0.0-native-fb-99da76f23a-20240606";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<61df2a3442301186080662e07ae6861c>>
10+
* @generated SignedSource<<d789297d22614ff6eb7e163ab91204f4>>
1111
*/
1212

1313
"use strict";
@@ -608,7 +608,7 @@ exports.useSyncExternalStore = function (
608608
exports.useTransition = function () {
609609
return ReactSharedInternals.H.useTransition();
610610
};
611-
exports.version = "19.0.0-native-fb-704aeed022-20240605";
611+
exports.version = "19.0.0-native-fb-99da76f23a-20240606";
612612
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
613613
"function" ===
614614
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
704aeed022f4277cd5604bf6d76199a6cfe4707f
1+
99da76f23ac85d279457470f8fb19a9b2f173ed0

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<4ac9313a3ba768bd6e6f00dec2ba7f4c>>
10+
* @generated SignedSource<<961245cc1a85b2c3470d0ad37e4b4278>>
1111
*/
1212

1313
'use strict';
@@ -26316,7 +26316,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
2631626316
return root;
2631726317
}
2631826318

26319-
var ReactVersion = '19.0.0-rc-704aeed022-20240605';
26319+
var ReactVersion = '19.0.0-rc-99da76f23a-20240606';
2632026320

2632126321
/*
2632226322
* The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<c4d2ac334f3ed7878016aa395f9d04ca>>
10+
* @generated SignedSource<<a362d8aac3277fadd6d410e4444f33bf>>
1111
*/
1212

1313
"use strict";
@@ -10591,7 +10591,7 @@ var roots = new Map(),
1059110591
devToolsConfig$jscomp$inline_1125 = {
1059210592
findFiberByHostInstance: getInstanceFromNode,
1059310593
bundleType: 0,
10594-
version: "19.0.0-rc-704aeed022-20240605",
10594+
version: "19.0.0-rc-99da76f23a-20240606",
1059510595
rendererPackageName: "react-native-renderer",
1059610596
rendererConfig: {
1059710597
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10634,7 +10634,7 @@ var internals$jscomp$inline_1351 = {
1063410634
scheduleRoot: null,
1063510635
setRefreshHandler: null,
1063610636
getCurrentFiber: null,
10637-
reconcilerVersion: "19.0.0-rc-704aeed022-20240605"
10637+
reconcilerVersion: "19.0.0-rc-99da76f23a-20240606"
1063810638
};
1063910639
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1064010640
var hook$jscomp$inline_1352 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

0 commit comments

Comments
 (0)