Skip to content

Commit 363a78f

Browse files
committed
Add dynamic disableModulePatternComponents flag for native-fb (#27739)
Makes `disableModulePatternComponents` a flag to allow us a slow rollout for RN internally. DiffTrain build for commit a3172e9.
1 parent eb3fd97 commit 363a78f

File tree

13 files changed

+98
-80
lines changed

13 files changed

+98
-80
lines changed

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25474,7 +25474,7 @@ if (__DEV__) {
2547425474
return root;
2547525475
}
2547625476

25477-
var ReactVersion = "18.3.0-canary-bbb9cb116-20231117";
25477+
var ReactVersion = "18.3.0-canary-a3172e933-20231122";
2547825478

2547925479
// Might add PROFILE later.
2548025480

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9083,7 +9083,7 @@ var devToolsConfig$jscomp$inline_1033 = {
90839083
throw Error("TestRenderer does not support findFiberByHostInstance()");
90849084
},
90859085
bundleType: 0,
9086-
version: "18.3.0-canary-bbb9cb116-20231117",
9086+
version: "18.3.0-canary-a3172e933-20231122",
90879087
rendererPackageName: "react-test-renderer"
90889088
};
90899089
var internals$jscomp$inline_1226 = {
@@ -9114,7 +9114,7 @@ var internals$jscomp$inline_1226 = {
91149114
scheduleRoot: null,
91159115
setRefreshHandler: null,
91169116
getCurrentFiber: null,
9117-
reconcilerVersion: "18.3.0-canary-bbb9cb116-20231117"
9117+
reconcilerVersion: "18.3.0-canary-a3172e933-20231122"
91189118
};
91199119
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
91209120
var hook$jscomp$inline_1227 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9509,7 +9509,7 @@ var devToolsConfig$jscomp$inline_1075 = {
95099509
throw Error("TestRenderer does not support findFiberByHostInstance()");
95109510
},
95119511
bundleType: 0,
9512-
version: "18.3.0-canary-bbb9cb116-20231117",
9512+
version: "18.3.0-canary-a3172e933-20231122",
95139513
rendererPackageName: "react-test-renderer"
95149514
};
95159515
var internals$jscomp$inline_1267 = {
@@ -9540,7 +9540,7 @@ var internals$jscomp$inline_1267 = {
95409540
scheduleRoot: null,
95419541
setRefreshHandler: null,
95429542
getCurrentFiber: null,
9543-
reconcilerVersion: "18.3.0-canary-bbb9cb116-20231117"
9543+
reconcilerVersion: "18.3.0-canary-a3172e933-20231122"
95449544
};
95459545
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
95469546
var hook$jscomp$inline_1268 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (__DEV__) {
2424
) {
2525
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
2626
}
27-
var ReactVersion = "18.3.0-canary-bbb9cb116-20231117";
27+
var ReactVersion = "18.3.0-canary-a3172e933-20231122";
2828

2929
// ATTENTION
3030
// When adding new symbols to this file,

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -580,4 +580,4 @@ exports.useSyncExternalStore = function (
580580
exports.useTransition = function () {
581581
return ReactCurrentDispatcher.current.useTransition();
582582
};
583-
exports.version = "18.3.0-canary-bbb9cb116-20231117";
583+
exports.version = "18.3.0-canary-a3172e933-20231122";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,7 @@ exports.useSyncExternalStore = function (
576576
exports.useTransition = function () {
577577
return ReactCurrentDispatcher.current.useTransition();
578578
};
579-
exports.version = "18.3.0-canary-bbb9cb116-20231117";
579+
exports.version = "18.3.0-canary-a3172e933-20231122";
580580
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
581581
"function" ===
582582
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
bbb9cb116dbf7b6247721aa0c4bcb6ec249aa8af
1+
a3172e933c7eb54aa02ec1d303453a96bc76181b

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<aaac73d7cc89a43a1238c55b03c67a4e>>
10+
* @generated SignedSource<<aeb13744feb3c4d52877eeb7f7905a51>>
1111
*/
1212

1313
"use strict";
@@ -3232,15 +3232,17 @@ to return true:wantsResponderID| |
32323232
// NOTE: There are no flags, currently. Uncomment the stuff below if we add one.
32333233
// the exports object every time a flag is read.
32343234

3235-
var enableUseRefAccessWarning = dynamicFlags.enableUseRefAccessWarning,
3235+
var alwaysThrottleRetries = dynamicFlags.alwaysThrottleRetries,
3236+
disableModulePatternComponents =
3237+
dynamicFlags.disableModulePatternComponents,
32363238
enableDeferRootSchedulingToMicrotask =
32373239
dynamicFlags.enableDeferRootSchedulingToMicrotask,
32383240
enableUnifiedSyncLane = dynamicFlags.enableUnifiedSyncLane,
3239-
alwaysThrottleRetries = dynamicFlags.alwaysThrottleRetries,
3240-
useMicrotasksForSchedulingInFabric =
3241-
dynamicFlags.useMicrotasksForSchedulingInFabric,
3241+
enableUseRefAccessWarning = dynamicFlags.enableUseRefAccessWarning,
32423242
passChildrenWhenCloningPersistedNodes =
3243-
dynamicFlags.passChildrenWhenCloningPersistedNodes; // The rest of the flags are static for better dead code elimination.
3243+
dynamicFlags.passChildrenWhenCloningPersistedNodes,
3244+
useMicrotasksForSchedulingInFabric =
3245+
dynamicFlags.useMicrotasksForSchedulingInFabric; // The rest of the flags are static for better dead code elimination.
32443246
var enableSchedulingProfiler = true;
32453247
var enableProfilerTimer = true;
32463248
var enableProfilerCommitHooks = true;
@@ -16795,6 +16797,7 @@ to return true:wantsResponderID| |
1679516797
if (
1679616798
// Run these checks in production only if the flag is off.
1679716799
// Eventually we'll delete this branch altogether.
16800+
!disableModulePatternComponents &&
1679816801
typeof value === "object" &&
1679916802
value !== null &&
1680016803
typeof value.render === "function" &&
@@ -27812,7 +27815,7 @@ to return true:wantsResponderID| |
2781227815
return root;
2781327816
}
2781427817

27815-
var ReactVersion = "18.3.0-canary-a3a54342";
27818+
var ReactVersion = "18.3.0-canary-c34d6f72";
2781627819

2781727820
function createPortal$1(
2781827821
children,

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<c45396dc1efd10a6033e0b1852b0fe7f>>
10+
* @generated SignedSource<<3d433092fb21fe655546ab8cc86bfe96>>
1111
*/
1212

1313
"use strict";
@@ -1314,15 +1314,16 @@ function dispatchEvent(target, topLevelType, nativeEvent) {
13141314
}
13151315
});
13161316
}
1317-
var enableUseRefAccessWarning = dynamicFlags.enableUseRefAccessWarning,
1317+
var alwaysThrottleRetries = dynamicFlags.alwaysThrottleRetries,
1318+
disableModulePatternComponents = dynamicFlags.disableModulePatternComponents,
13181319
enableDeferRootSchedulingToMicrotask =
13191320
dynamicFlags.enableDeferRootSchedulingToMicrotask,
13201321
enableUnifiedSyncLane = dynamicFlags.enableUnifiedSyncLane,
1321-
alwaysThrottleRetries = dynamicFlags.alwaysThrottleRetries,
1322-
useMicrotasksForSchedulingInFabric =
1323-
dynamicFlags.useMicrotasksForSchedulingInFabric,
1322+
enableUseRefAccessWarning = dynamicFlags.enableUseRefAccessWarning,
13241323
passChildrenWhenCloningPersistedNodes =
13251324
dynamicFlags.passChildrenWhenCloningPersistedNodes,
1325+
useMicrotasksForSchedulingInFabric =
1326+
dynamicFlags.useMicrotasksForSchedulingInFabric,
13261327
scheduleCallback$2 = Scheduler.unstable_scheduleCallback,
13271328
cancelCallback$1 = Scheduler.unstable_cancelCallback,
13281329
shouldYield = Scheduler.unstable_shouldYield,
@@ -8628,11 +8629,16 @@ beginWork = function (current, workInProgress, renderLanes) {
86288629
);
86298630
workInProgress.flags |= 1;
86308631
if (
8631-
"object" === typeof context &&
8632-
null !== context &&
8633-
"function" === typeof context.render &&
8634-
void 0 === context.$$typeof
8635-
) {
8632+
disableModulePatternComponents ||
8633+
"object" !== typeof context ||
8634+
null === context ||
8635+
"function" !== typeof context.render ||
8636+
void 0 !== context.$$typeof
8637+
)
8638+
(workInProgress.tag = 0),
8639+
reconcileChildren(null, workInProgress, context, renderLanes),
8640+
(workInProgress = workInProgress.child);
8641+
else {
86368642
workInProgress.tag = 1;
86378643
workInProgress.memoizedState = null;
86388644
workInProgress.updateQueue = null;
@@ -8657,10 +8663,7 @@ beginWork = function (current, workInProgress, renderLanes) {
86578663
hasContext,
86588664
renderLanes
86598665
);
8660-
} else
8661-
(workInProgress.tag = 0),
8662-
reconcileChildren(null, workInProgress, context, renderLanes),
8663-
(workInProgress = workInProgress.child);
8666+
}
86648667
return workInProgress;
86658668
case 16:
86668669
Component = workInProgress.elementType;
@@ -9541,7 +9544,7 @@ var roots = new Map(),
95419544
devToolsConfig$jscomp$inline_1048 = {
95429545
findFiberByHostInstance: getInstanceFromNode,
95439546
bundleType: 0,
9544-
version: "18.3.0-canary-8f9ce9e2",
9547+
version: "18.3.0-canary-a0c4da55",
95459548
rendererPackageName: "react-native-renderer",
95469549
rendererConfig: {
95479550
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -9584,7 +9587,7 @@ var internals$jscomp$inline_1290 = {
95849587
scheduleRoot: null,
95859588
setRefreshHandler: null,
95869589
getCurrentFiber: null,
9587-
reconcilerVersion: "18.3.0-canary-8f9ce9e2"
9590+
reconcilerVersion: "18.3.0-canary-a0c4da55"
95889591
};
95899592
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
95909593
var hook$jscomp$inline_1291 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<cb300ed80629ca9a73c08e9fcad07bd0>>
10+
* @generated SignedSource<<c84472616bec5f450a6873c637335a4d>>
1111
*/
1212

1313
"use strict";
@@ -1318,15 +1318,16 @@ function dispatchEvent(target, topLevelType, nativeEvent) {
13181318
}
13191319
});
13201320
}
1321-
var enableUseRefAccessWarning = dynamicFlags.enableUseRefAccessWarning,
1321+
var alwaysThrottleRetries = dynamicFlags.alwaysThrottleRetries,
1322+
disableModulePatternComponents = dynamicFlags.disableModulePatternComponents,
13221323
enableDeferRootSchedulingToMicrotask =
13231324
dynamicFlags.enableDeferRootSchedulingToMicrotask,
13241325
enableUnifiedSyncLane = dynamicFlags.enableUnifiedSyncLane,
1325-
alwaysThrottleRetries = dynamicFlags.alwaysThrottleRetries,
1326-
useMicrotasksForSchedulingInFabric =
1327-
dynamicFlags.useMicrotasksForSchedulingInFabric,
1326+
enableUseRefAccessWarning = dynamicFlags.enableUseRefAccessWarning,
13281327
passChildrenWhenCloningPersistedNodes =
13291328
dynamicFlags.passChildrenWhenCloningPersistedNodes,
1329+
useMicrotasksForSchedulingInFabric =
1330+
dynamicFlags.useMicrotasksForSchedulingInFabric,
13301331
scheduleCallback$2 = Scheduler.unstable_scheduleCallback,
13311332
cancelCallback$1 = Scheduler.unstable_cancelCallback,
13321333
shouldYield = Scheduler.unstable_shouldYield,
@@ -9299,11 +9300,16 @@ beginWork = function (current, workInProgress, renderLanes) {
92999300
markComponentRenderStopped();
93009301
workInProgress.flags |= 1;
93019302
if (
9302-
"object" === typeof context &&
9303-
null !== context &&
9304-
"function" === typeof context.render &&
9305-
void 0 === context.$$typeof
9306-
) {
9303+
disableModulePatternComponents ||
9304+
"object" !== typeof context ||
9305+
null === context ||
9306+
"function" !== typeof context.render ||
9307+
void 0 !== context.$$typeof
9308+
)
9309+
(workInProgress.tag = 0),
9310+
reconcileChildren(null, workInProgress, context, renderLanes),
9311+
(workInProgress = workInProgress.child);
9312+
else {
93079313
workInProgress.tag = 1;
93089314
workInProgress.memoizedState = null;
93099315
workInProgress.updateQueue = null;
@@ -9328,10 +9334,7 @@ beginWork = function (current, workInProgress, renderLanes) {
93289334
hasContext,
93299335
renderLanes
93309336
);
9331-
} else
9332-
(workInProgress.tag = 0),
9333-
reconcileChildren(null, workInProgress, context, renderLanes),
9334-
(workInProgress = workInProgress.child);
9337+
}
93359338
return workInProgress;
93369339
case 16:
93379340
Component = workInProgress.elementType;
@@ -10243,7 +10246,7 @@ var roots = new Map(),
1024310246
devToolsConfig$jscomp$inline_1126 = {
1024410247
findFiberByHostInstance: getInstanceFromNode,
1024510248
bundleType: 0,
10246-
version: "18.3.0-canary-8a2d4f06",
10249+
version: "18.3.0-canary-e91c485a",
1024710250
rendererPackageName: "react-native-renderer",
1024810251
rendererConfig: {
1024910252
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10299,7 +10302,7 @@ var roots = new Map(),
1029910302
scheduleRoot: null,
1030010303
setRefreshHandler: null,
1030110304
getCurrentFiber: null,
10302-
reconcilerVersion: "18.3.0-canary-8a2d4f06"
10305+
reconcilerVersion: "18.3.0-canary-e91c485a"
1030310306
});
1030410307
exports.createPortal = function (children, containerTag) {
1030510308
return createPortal$1(

0 commit comments

Comments
 (0)