Skip to content

Commit 544e688

Browse files
yungstersyungsters
committed
Add alwaysThrottleDisappearingFallbacks Flag (#28550)
## Summary Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that gates the changes from #26802 (instead of being controlled by `alwaysThrottleRetries`). The values of this new flag mirror the current values of `alwaysThrottleRetries` such that there is no behavior difference. This additional feature flag allows us to incrementally validate the change (arguably bug fix) from #26802 independently from `alwaysThrottleRetries`. ## How did you test this change? ``` $ yarn test $ yarn flow dom-browser $ yarn flow dom-fb $ yarn flow fabric ``` DiffTrain build for commit 0aab065.
1 parent 256d1e2 commit 544e688

File tree

13 files changed

+47
-35
lines changed

13 files changed

+47
-35
lines changed

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25454,7 +25454,7 @@ if (__DEV__) {
2545425454
return root;
2545525455
}
2545625456

25457-
var ReactVersion = "18.3.0-canary-7959a1dd2-20240318";
25457+
var ReactVersion = "18.3.0-canary-0aab065eb-20240318";
2545825458

2545925459
// Might add PROFILE later.
2546025460

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9175,7 +9175,7 @@ var devToolsConfig$jscomp$inline_1016 = {
91759175
throw Error("TestRenderer does not support findFiberByHostInstance()");
91769176
},
91779177
bundleType: 0,
9178-
version: "18.3.0-canary-7959a1dd2-20240318",
9178+
version: "18.3.0-canary-0aab065eb-20240318",
91799179
rendererPackageName: "react-test-renderer"
91809180
};
91819181
var internals$jscomp$inline_1194 = {
@@ -9206,7 +9206,7 @@ var internals$jscomp$inline_1194 = {
92069206
scheduleRoot: null,
92079207
setRefreshHandler: null,
92089208
getCurrentFiber: null,
9209-
reconcilerVersion: "18.3.0-canary-7959a1dd2-20240318"
9209+
reconcilerVersion: "18.3.0-canary-0aab065eb-20240318"
92109210
};
92119211
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
92129212
var hook$jscomp$inline_1195 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9603,7 +9603,7 @@ var devToolsConfig$jscomp$inline_1058 = {
96039603
throw Error("TestRenderer does not support findFiberByHostInstance()");
96049604
},
96059605
bundleType: 0,
9606-
version: "18.3.0-canary-7959a1dd2-20240318",
9606+
version: "18.3.0-canary-0aab065eb-20240318",
96079607
rendererPackageName: "react-test-renderer"
96089608
};
96099609
var internals$jscomp$inline_1235 = {
@@ -9634,7 +9634,7 @@ var internals$jscomp$inline_1235 = {
96349634
scheduleRoot: null,
96359635
setRefreshHandler: null,
96369636
getCurrentFiber: null,
9637-
reconcilerVersion: "18.3.0-canary-7959a1dd2-20240318"
9637+
reconcilerVersion: "18.3.0-canary-0aab065eb-20240318"
96389638
};
96399639
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
96409640
var hook$jscomp$inline_1236 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ if (__DEV__) {
2626
}
2727
var dynamicFlags = require("ReactNativeInternalFeatureFlags");
2828

29-
var ReactVersion = "18.3.0-canary-7959a1dd2-20240318";
29+
var ReactVersion = "18.3.0-canary-0aab065eb-20240318";
3030

3131
// ATTENTION
3232
// When adding new symbols to this file,

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -628,4 +628,4 @@ exports.useSyncExternalStore = function (
628628
exports.useTransition = function () {
629629
return ReactCurrentDispatcher.current.useTransition();
630630
};
631-
exports.version = "18.3.0-canary-7959a1dd2-20240318";
631+
exports.version = "18.3.0-canary-0aab065eb-20240318";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -624,7 +624,7 @@ exports.useSyncExternalStore = function (
624624
exports.useTransition = function () {
625625
return ReactCurrentDispatcher.current.useTransition();
626626
};
627-
exports.version = "18.3.0-canary-7959a1dd2-20240318";
627+
exports.version = "18.3.0-canary-0aab065eb-20240318";
628628
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
629629
"function" ===
630630
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
7959a1dd28a8b0df9c80dc36bb51a4fa25123d3e
1+
0aab065eb3250a9714a62dc05587cbb571da7f71

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<e0529a44eea2a06c29b44e0f6f3094ea>>
10+
* @generated SignedSource<<d73b12c3f574028ed9e0ad9b51186c44>>
1111
*/
1212

1313
"use strict";
@@ -2972,7 +2972,9 @@ to return true:wantsResponderID| |
29722972
// NOTE: There are no flags, currently. Uncomment the stuff below if we add one.
29732973
// the exports object every time a flag is read.
29742974

2975-
var alwaysThrottleRetries = dynamicFlags.alwaysThrottleRetries,
2975+
var alwaysThrottleDisappearingFallbacks =
2976+
dynamicFlags.alwaysThrottleDisappearingFallbacks,
2977+
alwaysThrottleRetries = dynamicFlags.alwaysThrottleRetries,
29762978
consoleManagedByDevToolsDuringStrictMode =
29772979
dynamicFlags.consoleManagedByDevToolsDuringStrictMode,
29782980
enableAsyncActions = dynamicFlags.enableAsyncActions,
@@ -23729,7 +23731,7 @@ to return true:wantsResponderID| |
2372923731
var wasShowingFallback =
2373023732
current !== null && current.memoizedState !== null;
2373123733

23732-
if (alwaysThrottleRetries) {
23734+
if (alwaysThrottleDisappearingFallbacks) {
2373323735
if (isShowingFallback !== wasShowingFallback) {
2373423736
// A fallback is either appearing or disappearing.
2373523737
markCommitTimeOfFallback();
@@ -29801,7 +29803,7 @@ to return true:wantsResponderID| |
2980129803
return root;
2980229804
}
2980329805

29804-
var ReactVersion = "18.3.0-canary-dcb437de";
29806+
var ReactVersion = "18.3.0-canary-0088978b";
2980529807

2980629808
function createPortal$1(
2980729809
children,

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<bad8dcf29728fb2c7ec3ee84033aabb1>>
10+
* @generated SignedSource<<f6c7840d9ffe86249d3d1f2916cc36cf>>
1111
*/
1212

1313
"use strict";
@@ -1264,7 +1264,9 @@ function dispatchEvent(target, topLevelType, nativeEvent) {
12641264
}
12651265
});
12661266
}
1267-
var alwaysThrottleRetries = dynamicFlags.alwaysThrottleRetries,
1267+
var alwaysThrottleDisappearingFallbacks =
1268+
dynamicFlags.alwaysThrottleDisappearingFallbacks,
1269+
alwaysThrottleRetries = dynamicFlags.alwaysThrottleRetries,
12681270
consoleManagedByDevToolsDuringStrictMode =
12691271
dynamicFlags.consoleManagedByDevToolsDuringStrictMode,
12701272
enableAsyncActions = dynamicFlags.enableAsyncActions,
@@ -8350,7 +8352,7 @@ function commitMutationEffectsOnFiber(finishedWork, root) {
83508352
if (finishedWork.child.flags & 8192) {
83518353
var isShowingFallback = null !== finishedWork.memoizedState;
83528354
current = null !== current && null !== current.memoizedState;
8353-
alwaysThrottleRetries
8355+
alwaysThrottleDisappearingFallbacks
83548356
? isShowingFallback !== current &&
83558357
(globalMostRecentFallbackTime = now())
83568358
: isShowingFallback &&
@@ -10626,7 +10628,7 @@ var roots = new Map(),
1062610628
devToolsConfig$jscomp$inline_1103 = {
1062710629
findFiberByHostInstance: getInstanceFromNode,
1062810630
bundleType: 0,
10629-
version: "18.3.0-canary-45ebe421",
10631+
version: "18.3.0-canary-42c2e87d",
1063010632
rendererPackageName: "react-native-renderer",
1063110633
rendererConfig: {
1063210634
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10669,7 +10671,7 @@ var internals$jscomp$inline_1330 = {
1066910671
scheduleRoot: null,
1067010672
setRefreshHandler: null,
1067110673
getCurrentFiber: null,
10672-
reconcilerVersion: "18.3.0-canary-45ebe421"
10674+
reconcilerVersion: "18.3.0-canary-42c2e87d"
1067310675
};
1067410676
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1067510677
var hook$jscomp$inline_1331 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<26c28bc563c475bc48b8350e745dfaa4>>
10+
* @generated SignedSource<<92a5460b92f7a609cb3fc8d6b726415d>>
1111
*/
1212

1313
"use strict";
@@ -1268,7 +1268,9 @@ function dispatchEvent(target, topLevelType, nativeEvent) {
12681268
}
12691269
});
12701270
}
1271-
var alwaysThrottleRetries = dynamicFlags.alwaysThrottleRetries,
1271+
var alwaysThrottleDisappearingFallbacks =
1272+
dynamicFlags.alwaysThrottleDisappearingFallbacks,
1273+
alwaysThrottleRetries = dynamicFlags.alwaysThrottleRetries,
12721274
consoleManagedByDevToolsDuringStrictMode =
12731275
dynamicFlags.consoleManagedByDevToolsDuringStrictMode,
12741276
enableAsyncActions = dynamicFlags.enableAsyncActions,
@@ -8840,7 +8842,7 @@ function commitMutationEffectsOnFiber(finishedWork, root) {
88408842
if (finishedWork.child.flags & 8192) {
88418843
var isShowingFallback = null !== finishedWork.memoizedState;
88428844
current = null !== current && null !== current.memoizedState;
8843-
alwaysThrottleRetries
8845+
alwaysThrottleDisappearingFallbacks
88448846
? isShowingFallback !== current &&
88458847
(globalMostRecentFallbackTime = now$1())
88468848
: isShowingFallback &&
@@ -11332,7 +11334,7 @@ var roots = new Map(),
1133211334
devToolsConfig$jscomp$inline_1184 = {
1133311335
findFiberByHostInstance: getInstanceFromNode,
1133411336
bundleType: 0,
11335-
version: "18.3.0-canary-154313d4",
11337+
version: "18.3.0-canary-40c1e627",
1133611338
rendererPackageName: "react-native-renderer",
1133711339
rendererConfig: {
1133811340
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -11388,7 +11390,7 @@ var roots = new Map(),
1138811390
scheduleRoot: null,
1138911391
setRefreshHandler: null,
1139011392
getCurrentFiber: null,
11391-
reconcilerVersion: "18.3.0-canary-154313d4"
11393+
reconcilerVersion: "18.3.0-canary-40c1e627"
1139211394
});
1139311395
exports.createPortal = function (children, containerTag) {
1139411396
return createPortal$1(

0 commit comments

Comments
 (0)