Commit 608544b
committed
[Fizz] Push a stalled await from debug info to the ownerStack/debugTask (#33634)
If an aborted task is not rendering, then this is an async abort.
Conceptually it's as if the abort happened inside the async gap. The
abort reason's stack frame won't have that on the stack so instead we
use the owner stack and debug task of any halted async debug info.
One thing that's a bit awkward is that if you do have a sync abort and
you use that error as the "reason" then that thing still has a sync
stack in a different component. In another approach I was exploring
having different error objects for each component but I don't think
that's worth it.
DiffTrain build for [cee7939](cee7939)1 parent 3d92b7b commit 608544b
File tree
35 files changed
+110
-95
lines changed- compiled/facebook-www
35 files changed
+110
-95
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1479 | 1479 | | |
1480 | 1480 | | |
1481 | 1481 | | |
1482 | | - | |
| 1482 | + | |
1483 | 1483 | | |
1484 | 1484 | | |
1485 | 1485 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1479 | 1479 | | |
1480 | 1480 | | |
1481 | 1481 | | |
1482 | | - | |
| 1482 | + | |
1483 | 1483 | | |
1484 | 1484 | | |
1485 | 1485 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
630 | 630 | | |
631 | 631 | | |
632 | 632 | | |
633 | | - | |
| 633 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
630 | 630 | | |
631 | 631 | | |
632 | 632 | | |
633 | | - | |
| 633 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
634 | 634 | | |
635 | 635 | | |
636 | 636 | | |
637 | | - | |
| 637 | + | |
638 | 638 | | |
639 | 639 | | |
640 | 640 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
634 | 634 | | |
635 | 635 | | |
636 | 636 | | |
637 | | - | |
| 637 | + | |
638 | 638 | | |
639 | 639 | | |
640 | 640 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19073 | 19073 | | |
19074 | 19074 | | |
19075 | 19075 | | |
19076 | | - | |
| 19076 | + | |
19077 | 19077 | | |
19078 | 19078 | | |
19079 | | - | |
| 19079 | + | |
19080 | 19080 | | |
19081 | 19081 | | |
19082 | 19082 | | |
| |||
19110 | 19110 | | |
19111 | 19111 | | |
19112 | 19112 | | |
19113 | | - | |
| 19113 | + | |
19114 | 19114 | | |
19115 | 19115 | | |
19116 | 19116 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18845 | 18845 | | |
18846 | 18846 | | |
18847 | 18847 | | |
18848 | | - | |
| 18848 | + | |
18849 | 18849 | | |
18850 | 18850 | | |
18851 | | - | |
| 18851 | + | |
18852 | 18852 | | |
18853 | 18853 | | |
18854 | 18854 | | |
| |||
18882 | 18882 | | |
18883 | 18883 | | |
18884 | 18884 | | |
18885 | | - | |
| 18885 | + | |
18886 | 18886 | | |
18887 | 18887 | | |
18888 | 18888 | | |
| |||
0 commit comments