Skip to content

Commit 64c08bd

Browse files
potetopoteto
committed
[crud] Rename useResourceEffect flag (#32204)
Rename the flag in preparation for the overload. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32204). * #32206 * #32205 * __->__ #32204 DiffTrain build for [0461c0d](0461c0d)
1 parent 3574dcd commit 64c08bd

37 files changed

+352
-352
lines changed

‎compiled/facebook-www/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
899e3d1297ec15a5aa8d73e2f1bd478918090a12
1+
0461c0d8a49730d1c8ebca2071d9bb7adfc8ac92

‎compiled/facebook-www/REVISION_TRANSFORMS‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
899e3d1297ec15a5aa8d73e2f1bd478918090a12
1+
0461c0d8a49730d1c8ebca2071d9bb7adfc8ac92

‎compiled/facebook-www/React-dev.classic.js‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1018,7 +1018,7 @@ __DEV__ &&
10181018
updateDeps,
10191019
destroy
10201020
) {
1021-
if (!enableUseResourceEffectHook) throw Error("Not implemented.");
1021+
if (!enableUseEffectCRUDOverload) throw Error("Not implemented.");
10221022
return resolveDispatcher().useResourceEffect(
10231023
create,
10241024
createDeps,
@@ -1126,8 +1126,8 @@ __DEV__ &&
11261126
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
11271127
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
11281128
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
1129-
enableUseResourceEffectHook =
1130-
dynamicFeatureFlags.enableUseResourceEffectHook,
1129+
enableUseEffectCRUDOverload =
1130+
dynamicFeatureFlags.enableUseEffectCRUDOverload,
11311131
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
11321132
enableOwnerStacks = dynamicFeatureFlags.enableOwnerStacks,
11331133
enableViewTransition = dynamicFeatureFlags.enableViewTransition,
@@ -1334,7 +1334,7 @@ __DEV__ &&
13341334
return children;
13351335
}
13361336
},
1337-
experimental_useResourceEffect = enableUseResourceEffectHook
1337+
experimental_useResourceEffect = enableUseEffectCRUDOverload
13381338
? useResourceEffect
13391339
: void 0;
13401340
exports.captureOwnerStack = void 0;
@@ -1972,7 +1972,7 @@ __DEV__ &&
19721972
exports.useTransition = function () {
19731973
return resolveDispatcher().useTransition();
19741974
};
1975-
exports.version = "19.1.0-www-classic-899e3d12-20250211";
1975+
exports.version = "19.1.0-www-classic-0461c0d8-20250211";
19761976
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
19771977
"function" ===
19781978
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-dev.modern.js‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1018,7 +1018,7 @@ __DEV__ &&
10181018
updateDeps,
10191019
destroy
10201020
) {
1021-
if (!enableUseResourceEffectHook) throw Error("Not implemented.");
1021+
if (!enableUseEffectCRUDOverload) throw Error("Not implemented.");
10221022
return resolveDispatcher().useResourceEffect(
10231023
create,
10241024
createDeps,
@@ -1126,8 +1126,8 @@ __DEV__ &&
11261126
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
11271127
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
11281128
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
1129-
enableUseResourceEffectHook =
1130-
dynamicFeatureFlags.enableUseResourceEffectHook,
1129+
enableUseEffectCRUDOverload =
1130+
dynamicFeatureFlags.enableUseEffectCRUDOverload,
11311131
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
11321132
enableOwnerStacks = dynamicFeatureFlags.enableOwnerStacks,
11331133
enableViewTransition = dynamicFeatureFlags.enableViewTransition,
@@ -1334,7 +1334,7 @@ __DEV__ &&
13341334
return children;
13351335
}
13361336
},
1337-
experimental_useResourceEffect = enableUseResourceEffectHook
1337+
experimental_useResourceEffect = enableUseEffectCRUDOverload
13381338
? useResourceEffect
13391339
: void 0;
13401340
exports.captureOwnerStack = void 0;
@@ -1972,7 +1972,7 @@ __DEV__ &&
19721972
exports.useTransition = function () {
19731973
return resolveDispatcher().useTransition();
19741974
};
1975-
exports.version = "19.1.0-www-modern-899e3d12-20250211";
1975+
exports.version = "19.1.0-www-modern-0461c0d8-20250211";
19761976
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
19771977
"function" ===
19781978
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-prod.classic.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ var dynamicFeatureFlags = require("ReactFeatureFlags"),
1616
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
1717
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
1818
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
19-
enableUseResourceEffectHook = dynamicFeatureFlags.enableUseResourceEffectHook,
19+
enableUseEffectCRUDOverload = dynamicFeatureFlags.enableUseEffectCRUDOverload,
2020
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
2121
REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
2222
REACT_ELEMENT_TYPE = renameElementSymbol
@@ -326,7 +326,7 @@ function useMemoCache(size) {
326326
return ReactSharedInternals.H.useMemoCache(size);
327327
}
328328
function useResourceEffect(create, createDeps, update, updateDeps, destroy) {
329-
if (!enableUseResourceEffectHook) throw Error("Not implemented.");
329+
if (!enableUseEffectCRUDOverload) throw Error("Not implemented.");
330330
return ReactSharedInternals.H.useResourceEffect(
331331
create,
332332
createDeps,
@@ -366,7 +366,7 @@ var reportGlobalError =
366366
};
367367
function noop() {}
368368
var ReactCompilerRuntime = { __proto__: null, c: useMemoCache },
369-
experimental_useResourceEffect = enableUseResourceEffectHook
369+
experimental_useResourceEffect = enableUseEffectCRUDOverload
370370
? useResourceEffect
371371
: void 0;
372372
exports.Children = {
@@ -639,4 +639,4 @@ exports.useSyncExternalStore = function (
639639
exports.useTransition = function () {
640640
return ReactSharedInternals.H.useTransition();
641641
};
642-
exports.version = "19.1.0-www-classic-899e3d12-20250211";
642+
exports.version = "19.1.0-www-classic-0461c0d8-20250211";

‎compiled/facebook-www/React-prod.modern.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ var dynamicFeatureFlags = require("ReactFeatureFlags"),
1616
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
1717
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
1818
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
19-
enableUseResourceEffectHook = dynamicFeatureFlags.enableUseResourceEffectHook,
19+
enableUseEffectCRUDOverload = dynamicFeatureFlags.enableUseEffectCRUDOverload,
2020
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
2121
REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
2222
REACT_ELEMENT_TYPE = renameElementSymbol
@@ -326,7 +326,7 @@ function useMemoCache(size) {
326326
return ReactSharedInternals.H.useMemoCache(size);
327327
}
328328
function useResourceEffect(create, createDeps, update, updateDeps, destroy) {
329-
if (!enableUseResourceEffectHook) throw Error("Not implemented.");
329+
if (!enableUseEffectCRUDOverload) throw Error("Not implemented.");
330330
return ReactSharedInternals.H.useResourceEffect(
331331
create,
332332
createDeps,
@@ -366,7 +366,7 @@ var reportGlobalError =
366366
};
367367
function noop() {}
368368
var ReactCompilerRuntime = { __proto__: null, c: useMemoCache },
369-
experimental_useResourceEffect = enableUseResourceEffectHook
369+
experimental_useResourceEffect = enableUseEffectCRUDOverload
370370
? useResourceEffect
371371
: void 0;
372372
exports.Children = {
@@ -639,4 +639,4 @@ exports.useSyncExternalStore = function (
639639
exports.useTransition = function () {
640640
return ReactSharedInternals.H.useTransition();
641641
};
642-
exports.version = "19.1.0-www-modern-899e3d12-20250211";
642+
exports.version = "19.1.0-www-modern-0461c0d8-20250211";

‎compiled/facebook-www/React-profiling.classic.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ var dynamicFeatureFlags = require("ReactFeatureFlags"),
2020
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
2121
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
2222
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
23-
enableUseResourceEffectHook = dynamicFeatureFlags.enableUseResourceEffectHook,
23+
enableUseEffectCRUDOverload = dynamicFeatureFlags.enableUseEffectCRUDOverload,
2424
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
2525
REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
2626
REACT_ELEMENT_TYPE = renameElementSymbol
@@ -330,7 +330,7 @@ function useMemoCache(size) {
330330
return ReactSharedInternals.H.useMemoCache(size);
331331
}
332332
function useResourceEffect(create, createDeps, update, updateDeps, destroy) {
333-
if (!enableUseResourceEffectHook) throw Error("Not implemented.");
333+
if (!enableUseEffectCRUDOverload) throw Error("Not implemented.");
334334
return ReactSharedInternals.H.useResourceEffect(
335335
create,
336336
createDeps,
@@ -370,7 +370,7 @@ var reportGlobalError =
370370
};
371371
function noop() {}
372372
var ReactCompilerRuntime = { __proto__: null, c: useMemoCache },
373-
experimental_useResourceEffect = enableUseResourceEffectHook
373+
experimental_useResourceEffect = enableUseEffectCRUDOverload
374374
? useResourceEffect
375375
: void 0;
376376
exports.Children = {
@@ -643,7 +643,7 @@ exports.useSyncExternalStore = function (
643643
exports.useTransition = function () {
644644
return ReactSharedInternals.H.useTransition();
645645
};
646-
exports.version = "19.1.0-www-classic-899e3d12-20250211";
646+
exports.version = "19.1.0-www-classic-0461c0d8-20250211";
647647
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
648648
"function" ===
649649
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-profiling.modern.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ var dynamicFeatureFlags = require("ReactFeatureFlags"),
2020
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
2121
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
2222
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
23-
enableUseResourceEffectHook = dynamicFeatureFlags.enableUseResourceEffectHook,
23+
enableUseEffectCRUDOverload = dynamicFeatureFlags.enableUseEffectCRUDOverload,
2424
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
2525
REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
2626
REACT_ELEMENT_TYPE = renameElementSymbol
@@ -330,7 +330,7 @@ function useMemoCache(size) {
330330
return ReactSharedInternals.H.useMemoCache(size);
331331
}
332332
function useResourceEffect(create, createDeps, update, updateDeps, destroy) {
333-
if (!enableUseResourceEffectHook) throw Error("Not implemented.");
333+
if (!enableUseEffectCRUDOverload) throw Error("Not implemented.");
334334
return ReactSharedInternals.H.useResourceEffect(
335335
create,
336336
createDeps,
@@ -370,7 +370,7 @@ var reportGlobalError =
370370
};
371371
function noop() {}
372372
var ReactCompilerRuntime = { __proto__: null, c: useMemoCache },
373-
experimental_useResourceEffect = enableUseResourceEffectHook
373+
experimental_useResourceEffect = enableUseEffectCRUDOverload
374374
? useResourceEffect
375375
: void 0;
376376
exports.Children = {
@@ -643,7 +643,7 @@ exports.useSyncExternalStore = function (
643643
exports.useTransition = function () {
644644
return ReactSharedInternals.H.useTransition();
645645
};
646-
exports.version = "19.1.0-www-modern-899e3d12-20250211";
646+
exports.version = "19.1.0-www-modern-0461c0d8-20250211";
647647
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
648648
"function" ===
649649
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/ReactART-dev.classic.js‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -9670,7 +9670,7 @@ __DEV__ &&
96709670
finishedWork
96719671
)),
96729672
(lastEffect = void 0),
9673-
enableUseResourceEffectHook &&
9673+
enableUseEffectCRUDOverload &&
96749674
(updateQueue.resourceKind === ResourceEffectIdentityKind &&
96759675
((updateQueue.inst.resource = runWithFiberInDEV(
96769676
finishedWork,
@@ -9694,7 +9694,7 @@ __DEV__ &&
96949694
)),
96959695
(flags & Insertion) !== NoFlags &&
96969696
(isRunningInsertionEffect = !0),
9697-
enableUseResourceEffectHook
9697+
enableUseEffectCRUDOverload
96989698
? null == updateQueue.resourceKind &&
96999699
(lastEffect = runWithFiberInDEV(
97009700
finishedWork,
@@ -9729,7 +9729,7 @@ __DEV__ &&
97299729
? "useLayoutEffect"
97309730
: 0 !== (updateQueue.tag & Insertion)
97319731
? "useInsertionEffect"
9732-
: enableUseResourceEffectHook &&
9732+
: enableUseEffectCRUDOverload &&
97339733
null != updateQueue.resourceKind
97349734
? "useResourceEffect"
97359735
: "useEffect";
@@ -9780,7 +9780,7 @@ __DEV__ &&
97809780
var inst = updateQueue.inst,
97819781
destroy = inst.destroy;
97829782
if (void 0 !== destroy) {
9783-
enableUseResourceEffectHook
9783+
enableUseEffectCRUDOverload
97849784
? null == updateQueue.resourceKind && (inst.destroy = void 0)
97859785
: (inst.destroy = void 0);
97869786
enableSchedulingProfiler &&
@@ -9802,7 +9802,7 @@ __DEV__ &&
98029802
));
98039803
(flags & Insertion) !== NoFlags &&
98049804
(isRunningInsertionEffect = !0);
9805-
if (enableUseResourceEffectHook) {
9805+
if (enableUseEffectCRUDOverload) {
98069806
if (
98079807
updateQueue.resourceKind === ResourceEffectIdentityKind &&
98089808
null != updateQueue.inst.resource
@@ -15164,8 +15164,8 @@ __DEV__ &&
1516415164
enableRetryLaneExpiration = dynamicFeatureFlags.enableRetryLaneExpiration,
1516515165
enableSiblingPrerendering = dynamicFeatureFlags.enableSiblingPrerendering,
1516615166
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
15167-
enableUseResourceEffectHook =
15168-
dynamicFeatureFlags.enableUseResourceEffectHook,
15167+
enableUseEffectCRUDOverload =
15168+
dynamicFeatureFlags.enableUseEffectCRUDOverload,
1516915169
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
1517015170
retryLaneExpirationMs = dynamicFeatureFlags.retryLaneExpirationMs,
1517115171
syncLaneExpirationMs = dynamicFeatureFlags.syncLaneExpirationMs,
@@ -15643,7 +15643,7 @@ __DEV__ &&
1564315643
useCacheRefresh: throwInvalidHookError
1564415644
};
1564515645
ContextOnlyDispatcher.useEffectEvent = throwInvalidHookError;
15646-
enableUseResourceEffectHook &&
15646+
enableUseEffectCRUDOverload &&
1564715647
(ContextOnlyDispatcher.useResourceEffect = throwInvalidHookError);
1564815648
var HooksDispatcherOnMountInDEV = null,
1564915649
HooksDispatcherOnMountWithHookTypesInDEV = null,
@@ -15784,7 +15784,7 @@ __DEV__ &&
1578415784
return mountEvent(callback);
1578515785
}
1578615786
};
15787-
enableUseResourceEffectHook &&
15787+
enableUseEffectCRUDOverload &&
1578815788
(HooksDispatcherOnMountInDEV.useResourceEffect = function (
1578915789
create,
1579015790
createDeps,
@@ -15936,7 +15936,7 @@ __DEV__ &&
1593615936
return mountEvent(callback);
1593715937
}
1593815938
};
15939-
enableUseResourceEffectHook &&
15939+
enableUseEffectCRUDOverload &&
1594015940
(HooksDispatcherOnMountWithHookTypesInDEV.useResourceEffect = function (
1594115941
create,
1594215942
createDeps,
@@ -16080,7 +16080,7 @@ __DEV__ &&
1608016080
return updateEvent(callback);
1608116081
}
1608216082
};
16083-
enableUseResourceEffectHook &&
16083+
enableUseEffectCRUDOverload &&
1608416084
(HooksDispatcherOnUpdateInDEV.useResourceEffect = function (
1608516085
create,
1608616086
createDeps,
@@ -16226,7 +16226,7 @@ __DEV__ &&
1622616226
return updateEvent(callback);
1622716227
}
1622816228
};
16229-
enableUseResourceEffectHook &&
16229+
enableUseEffectCRUDOverload &&
1623016230
(HooksDispatcherOnRerenderInDEV.useResourceEffect = function (
1623116231
create,
1623216232
createDeps,
@@ -16397,7 +16397,7 @@ __DEV__ &&
1639716397
return mountEvent(callback);
1639816398
}
1639916399
};
16400-
enableUseResourceEffectHook &&
16400+
enableUseEffectCRUDOverload &&
1640116401
(InvalidNestedHooksDispatcherOnMountInDEV.useResourceEffect = function (
1640216402
create,
1640316403
createDeps,
@@ -16567,7 +16567,7 @@ __DEV__ &&
1656716567
return updateEvent(callback);
1656816568
}
1656916569
};
16570-
enableUseResourceEffectHook &&
16570+
enableUseEffectCRUDOverload &&
1657116571
(InvalidNestedHooksDispatcherOnUpdateInDEV.useResourceEffect = function (
1657216572
create,
1657316573
createDeps,
@@ -16739,7 +16739,7 @@ __DEV__ &&
1673916739
return updateEvent(callback);
1674016740
}
1674116741
};
16742-
enableUseResourceEffectHook &&
16742+
enableUseEffectCRUDOverload &&
1674316743
(InvalidNestedHooksDispatcherOnRerenderInDEV.useResourceEffect =
1674416744
function (create, createDeps, update, updateDeps, destroy) {
1674516745
currentHookNameInDev = "useResourceEffect";
@@ -16839,7 +16839,7 @@ __DEV__ &&
1683916839
].bind(callComponentWillUnmount),
1684016840
callCreate = {
1684116841
"react-stack-bottom-frame": function (effect) {
16842-
if (enableUseResourceEffectHook) {
16842+
if (enableUseEffectCRUDOverload) {
1684316843
if (null == effect.resourceKind) {
1684416844
var _create = effect.create;
1684516845
effect = effect.inst;
@@ -16863,7 +16863,7 @@ __DEV__ &&
1686316863
return (
1686416864
null != effect.resourceKind &&
1686516865
error$jscomp$0(
16866-
"Expected only SimpleEffects when enableUseResourceEffectHook is disabled, got %s",
16866+
"Expected only SimpleEffects when enableUseEffectCRUDOverload is disabled, got %s",
1686716867
effect.resourceKind
1686816868
),
1686916869
(_create = effect.create),
@@ -17413,10 +17413,10 @@ __DEV__ &&
1741317413
(function () {
1741417414
var internals = {
1741517415
bundleType: 1,
17416-
version: "19.1.0-www-classic-899e3d12-20250211",
17416+
version: "19.1.0-www-classic-0461c0d8-20250211",
1741717417
rendererPackageName: "react-art",
1741817418
currentDispatcherRef: ReactSharedInternals,
17419-
reconcilerVersion: "19.1.0-www-classic-899e3d12-20250211"
17419+
reconcilerVersion: "19.1.0-www-classic-0461c0d8-20250211"
1742017420
};
1742117421
internals.overrideHookState = overrideHookState;
1742217422
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -17450,7 +17450,7 @@ __DEV__ &&
1745017450
exports.Shape = Shape;
1745117451
exports.Surface = Surface;
1745217452
exports.Text = Text;
17453-
exports.version = "19.1.0-www-classic-899e3d12-20250211";
17453+
exports.version = "19.1.0-www-classic-0461c0d8-20250211";
1745417454
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1745517455
"function" ===
1745617456
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)