Skip to content

Commit 6fac743

Browse files
committed
[circleci] Inline scrape_warning_messages
This job was only being used for process_artifacts_combined in circleci but as it was a separate job would incur the cost and time of spinning up a new CI worker. We can simply inline this into process_artifacts_combined. Test plan: Download [build.tgz](https://app.circleci.com/pipelines/github/facebook/react/57183/workflows/3b22a99e-b8a5-4c80-9682-576f24581b00/jobs/956476/artifacts) from circleci and observe that the __test_utils__ directory is still present. ghstack-source-id: 8748d8f Pull Request resolved: #30388
1 parent 7af570c commit 6fac743

File tree

1 file changed

+4
-23
lines changed

1 file changed

+4
-23
lines changed

.circleci/config.yml

Lines changed: 4 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -48,22 +48,6 @@ parameters:
4848
default: ''
4949

5050
jobs:
51-
scrape_warning_messages:
52-
docker: *docker
53-
environment: *environment
54-
55-
steps:
56-
- checkout
57-
- setup_node_modules
58-
- run:
59-
command: |
60-
mkdir -p ./build/__test_utils__
61-
node ./scripts/print-warnings/print-warnings.js > build/__test_utils__/ReactAllWarnings.js
62-
- persist_to_workspace:
63-
root: .
64-
paths:
65-
- build
66-
6751
yarn_build:
6852
docker: *docker
6953
environment: *environment
@@ -106,7 +90,10 @@ jobs:
10690
at: .
10791
- setup_node_modules
10892
- run: echo "<< pipeline.git.revision >>" >> build/COMMIT_SHA
109-
# Compress build directory into a single tarball for easy download
93+
- run: |
94+
mkdir -p ./build/__test_utils__
95+
node ./scripts/print-warnings/print-warnings.js > build/__test_utils__/ReactAllWarnings.js
96+
# Compress build directory into a single tarball for easy download
11097
- run: tar -zcvf ./build.tgz ./build
11198
# TODO: Migrate scripts to use `build` directory instead of `build2`
11299
- run: cp ./build.tgz ./build2.tgz
@@ -230,14 +217,8 @@ workflows:
230217
branches:
231218
ignore:
232219
- builds/facebook-www
233-
- scrape_warning_messages:
234-
filters:
235-
branches:
236-
ignore:
237-
- builds/facebook-www
238220
- process_artifacts_combined:
239221
requires:
240-
- scrape_warning_messages
241222
- yarn_build
242223

243224
devtools_regression_tests:

0 commit comments

Comments
 (0)