Skip to content

Commit 79671eb

Browse files
author
Keyan Zhang
committed
big refactoring.
- move implementation of dev-only modules under a __DEV__ block. this ensures good DCE result for webpack/browserify users and FB's packager. - an explicit 'Dev' postfix is added to their module names modules renamed: - ReactElementValidator.js -> ReactElementValidatorDev.js - ReactComponentTreeDevtool.js -> ReactComponentTreeDevtoolDev.js - validateDOMNesting.js -> validateDOMNestingDev.js - ReactDOMDebugTool.js -> ReactDOMDebugToolDev.js - ReactDOMNullInputValuePropDevtool.js -> ReactDOMNullInputValuePropDevtoolDev.js - ReactDOMUnknownPropertyDevtool.js -> ReactDOMUnknownPropertyDevtoolDev.js - ReactDebugTool.js -> ReactDebugToolDev.js - ReactInstrumentation.js -> ReactInstrumentationDev.js - ReactPerf.js -> ReactPerfDev.js - ReactChildrenMutationWarningDevtool.js -> ReactChildrenMutationWarningDevtoolDev.js - ReactHostOperationHistoryDevtool.js -> ReactHostOperationHistoryDevtoolDev.js - ReactInvalidSetStateWarningDevTool.js -> ReactInvalidSetStateWarningDevToolDev.js - canDefineProperty.js -> canDefinePropertyDev.js
1 parent 499acd4 commit 79671eb

File tree

63 files changed

+2027
-1991
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

63 files changed

+2027
-1991
lines changed

src/addons/ReactWithAddons.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ var ReactComponentWithPureRenderMixin =
1717
require('ReactComponentWithPureRenderMixin');
1818
var ReactCSSTransitionGroup = require('ReactCSSTransitionGroup');
1919
var ReactFragment = require('ReactFragment');
20-
var ReactPerf = require('ReactPerf');
20+
var ReactPerfDev = require('ReactPerfDev');
2121
var ReactTestUtils = require('ReactTestUtils');
2222
var ReactTransitionGroup = require('ReactTransitionGroup');
2323

@@ -36,7 +36,7 @@ React.addons = {
3636
};
3737

3838
if (__DEV__) {
39-
React.addons.Perf = ReactPerf;
39+
React.addons.Perf = ReactPerfDev;
4040
React.addons.TestUtils = ReactTestUtils;
4141
}
4242

src/isomorphic/React.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ var ReactPureComponent = require('ReactPureComponent');
1717
var ReactClass = require('ReactClass');
1818
var ReactDOMFactories = require('ReactDOMFactories');
1919
var ReactElement = require('ReactElement');
20-
var ReactElementValidator = require('ReactElementValidator');
20+
var ReactElementValidatorDev = require('ReactElementValidatorDev');
2121
var ReactPropTypes = require('ReactPropTypes');
2222
var ReactVersion = require('ReactVersion');
2323

@@ -29,9 +29,9 @@ var createFactory = ReactElement.createFactory;
2929
var cloneElement = ReactElement.cloneElement;
3030

3131
if (__DEV__) {
32-
createElement = ReactElementValidator.createElement;
33-
createFactory = ReactElementValidator.createFactory;
34-
cloneElement = ReactElementValidator.cloneElement;
32+
createElement = ReactElementValidatorDev.createElement;
33+
createFactory = ReactElementValidatorDev.createFactory;
34+
cloneElement = ReactElementValidatorDev.cloneElement;
3535
}
3636

3737
var __spread = Object.assign;

src/isomorphic/classic/element/ReactDOMFactories.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
'use strict';
1313

1414
var ReactElement = require('ReactElement');
15-
var ReactElementValidator = require('ReactElementValidator');
15+
var ReactElementValidatorDev = require('ReactElementValidatorDev');
1616

1717
var mapObject = require('mapObject');
1818

@@ -24,7 +24,7 @@ var mapObject = require('mapObject');
2424
*/
2525
function createDOMFactory(tag) {
2626
if (__DEV__) {
27-
return ReactElementValidator.createFactory(tag);
27+
return ReactElementValidatorDev.createFactory(tag);
2828
}
2929
return ReactElement.createFactory(tag);
3030
}

src/isomorphic/classic/element/ReactElement.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
var ReactCurrentOwner = require('ReactCurrentOwner');
1515

1616
var warning = require('warning');
17-
var canDefineProperty = require('canDefineProperty');
17+
var canDefinePropertyDev = require('canDefinePropertyDev');
1818
var hasOwnProperty = Object.prototype.hasOwnProperty;
1919

2020
// The Symbol used to tag the ReactElement type. If there is no native Symbol
@@ -103,7 +103,7 @@ var ReactElement = function(type, key, ref, self, source, owner, props) {
103103
// the validation flag non-enumerable (where possible, which should
104104
// include every environment we run tests in), so the test framework
105105
// ignores it.
106-
if (canDefineProperty) {
106+
if (canDefinePropertyDev) {
107107
Object.defineProperty(element._store, 'validated', {
108108
configurable: false,
109109
enumerable: false,

src/isomorphic/classic/element/ReactElementValidator.js

Lines changed: 0 additions & 269 deletions
This file was deleted.

0 commit comments

Comments
 (0)