Skip to content

Commit 7fdc64c

Browse files
committed
[flow] enable exact_empty_objects (#25973)
This enables the "exact_empty_objects" setting for Flow which makes empty objects exact instead of building up the type as properties are added in code below. This is in preparation to Flow 191 which makes this the default and removes the config. More about the change in the Flow blog [here](https://medium.com/flow-type/improved-handling-of-the-empty-object-in-flow-ead91887e40c). DiffTrain build for [e2424f3](e2424f3) [View git log for this commit](https://github.com/facebook/react/commits/e2424f33b3ad727321fc12e75c5e94838e84c2b5)
1 parent 3075524 commit 7fdc64c

28 files changed

+86
-62
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0b4f443020af386f2b48c47c074cb504ed672dc8
1+
e2424f33b3ad727321fc12e75c5e94838e84c2b5
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0b4f443020af386f2b48c47c074cb504ed672dc8
1+
e2424f33b3ad727321fc12e75c5e94838e84c2b5

compiled/facebook-www/React-dev.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-www-classic-0b4f44302-20230109";
30+
var ReactVersion = "18.3.0-www-classic-e2424f33b-20230109";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,
@@ -3089,15 +3089,15 @@ function startTransition(scope, options) {
30893089
if (prevTransition === null && currentTransition._updatedFibers) {
30903090
var updatedFibersCount = currentTransition._updatedFibers.size;
30913091

3092+
currentTransition._updatedFibers.clear();
3093+
30923094
if (updatedFibersCount > 10) {
30933095
warn(
30943096
"Detected a large number of updates inside startTransition. " +
30953097
"If this is due to a subscription please re-write it to use React provided hooks. " +
30963098
"Otherwise concurrent mode guarantees are off the table."
30973099
);
30983100
}
3099-
3100-
currentTransition._updatedFibers.clear();
31013101
}
31023102
}
31033103
}

compiled/facebook-www/React-dev.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-www-modern-0b4f44302-20230109";
30+
var ReactVersion = "18.3.0-www-modern-e2424f33b-20230109";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,
@@ -3055,15 +3055,15 @@ function startTransition(scope, options) {
30553055
if (prevTransition === null && currentTransition._updatedFibers) {
30563056
var updatedFibersCount = currentTransition._updatedFibers.size;
30573057

3058+
currentTransition._updatedFibers.clear();
3059+
30583060
if (updatedFibersCount > 10) {
30593061
warn(
30603062
"Detected a large number of updates inside startTransition. " +
30613063
"If this is due to a subscription please re-write it to use React provided hooks. " +
30623064
"Otherwise concurrent mode guarantees are off the table."
30633065
);
30643066
}
3065-
3066-
currentTransition._updatedFibers.clear();
30673067
}
30683068
}
30693069
}

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -643,4 +643,4 @@ exports.useSyncExternalStore = function(
643643
);
644644
};
645645
exports.useTransition = useTransition;
646-
exports.version = "18.3.0-www-classic-0b4f44302-20230109";
646+
exports.version = "18.3.0-www-classic-e2424f33b-20230109";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -635,4 +635,4 @@ exports.useSyncExternalStore = function(
635635
);
636636
};
637637
exports.useTransition = useTransition;
638-
exports.version = "18.3.0-www-modern-0b4f44302-20230109";
638+
exports.version = "18.3.0-www-modern-e2424f33b-20230109";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -654,7 +654,7 @@ exports.useSyncExternalStore = function(
654654
);
655655
};
656656
exports.useTransition = useTransition;
657-
exports.version = "18.3.0-www-classic-0b4f44302-20230109";
657+
exports.version = "18.3.0-www-classic-e2424f33b-20230109";
658658

659659
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
660660
if (

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -646,7 +646,7 @@ exports.useSyncExternalStore = function(
646646
);
647647
};
648648
exports.useTransition = useTransition;
649-
exports.version = "18.3.0-www-modern-0b4f44302-20230109";
649+
exports.version = "18.3.0-www-modern-e2424f33b-20230109";
650650

651651
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
652652
if (

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
6969
return self;
7070
}
7171

72-
var ReactVersion = "18.3.0-www-classic-0b4f44302-20230109";
72+
var ReactVersion = "18.3.0-www-classic-e2424f33b-20230109";
7373

7474
var LegacyRoot = 0;
7575
var ConcurrentRoot = 1;
@@ -9280,15 +9280,15 @@ function startTransition(setPending, callback, options) {
92809280
if (prevTransition === null && currentTransition._updatedFibers) {
92819281
var updatedFibersCount = currentTransition._updatedFibers.size;
92829282

9283+
currentTransition._updatedFibers.clear();
9284+
92839285
if (updatedFibersCount > 10) {
92849286
warn(
92859287
"Detected a large number of updates inside startTransition. " +
92869288
"If this is due to a subscription please re-write it to use React provided hooks. " +
92879289
"Otherwise concurrent mode guarantees are off the table."
92889290
);
92899291
}
9290-
9291-
currentTransition._updatedFibers.clear();
92929292
}
92939293
}
92949294
}

compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
6969
return self;
7070
}
7171

72-
var ReactVersion = "18.3.0-www-modern-0b4f44302-20230109";
72+
var ReactVersion = "18.3.0-www-modern-e2424f33b-20230109";
7373

7474
var LegacyRoot = 0;
7575
var ConcurrentRoot = 1;
@@ -9042,15 +9042,15 @@ function startTransition(setPending, callback, options) {
90429042
if (prevTransition === null && currentTransition._updatedFibers) {
90439043
var updatedFibersCount = currentTransition._updatedFibers.size;
90449044

9045+
currentTransition._updatedFibers.clear();
9046+
90459047
if (updatedFibersCount > 10) {
90469048
warn(
90479049
"Detected a large number of updates inside startTransition. " +
90489050
"If this is due to a subscription please re-write it to use React provided hooks. " +
90499051
"Otherwise concurrent mode guarantees are off the table."
90509052
);
90519053
}
9052-
9053-
currentTransition._updatedFibers.clear();
90549054
}
90559055
}
90569056
}

0 commit comments

Comments
 (0)