Skip to content

Commit 89580f2

Browse files
authored
Set renameElementSymbol to dynamic value (#30066)
Prepare to roll this out with dynamic flag `yarn flags --diff www canary` <img width="514" alt="Screenshot 2024-06-24 at 11 33 55 AM" src="https://github.com/facebook/react/assets/8965173/31508fdc-4cb1-4ce0-8e22-c02a034377b0">
1 parent c21bcd6 commit 89580f2

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

packages/react-dom/src/__tests__/ReactDOMOption-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ describe('ReactDOMOption', () => {
134134
}).rejects.toThrow('Objects are not valid as a React child');
135135
});
136136

137-
// @gate www
137+
// @gate www && !renameElementSymbol
138138
it('should support element-ish child', async () => {
139139
// This is similar to <fbt>.
140140
// We don't toString it because you must instead provide a value prop.

packages/shared/forks/ReactFeatureFlags.www-dynamic.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ export const syncLaneExpirationMs = 250;
3232
export const transitionLaneExpirationMs = 5000;
3333
export const enableAddPropertiesFastPath = __VARIANT__;
3434
export const disableLegacyMode = __VARIANT__;
35+
export const renameElementSymbol = __VARIANT__;
3536

3637
// Enable this flag to help with concurrent mode debugging.
3738
// It logs information to the console about React scheduling, rendering, and commit phases.

packages/shared/forks/ReactFeatureFlags.www.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ export const {
3535
enableNoCloningMemoCache,
3636
enableAddPropertiesFastPath,
3737
enableFastJSX,
38+
renameElementSymbol,
3839
} = dynamicFeatureFlags;
3940

4041
// On WWW, __EXPERIMENTAL__ is used for a new modern build.
@@ -65,8 +66,6 @@ export const enableSchedulingProfiler: boolean =
6566
export const disableLegacyContext = __EXPERIMENTAL__;
6667
export const enableGetInspectorDataForInstanceInProduction = false;
6768

68-
export const renameElementSymbol = false;
69-
7069
export const enableCache = true;
7170
export const enableLegacyCache = true;
7271

0 commit comments

Comments
 (0)