Merge pull request #3552 from James-Dunn/fix-for-loops

Remove caching from for loops

Author: zpao

src/browser/ReactBrowserEventEmitter.js

@@ -216,7 +216,7 @@ var ReactBrowserEventEmitter = assign({}, ReactEventEmitterMixin, {
       registrationNameDependencies[registrationName];
 
     var topLevelTypes = EventConstants.topLevelTypes;
-    for (var i = 0, l = dependencies.length; i < l; i++) {
+    for (var i = 0; i < dependencies.length; i++) {
       var dependency = dependencies[i];
       if (!(
             isListening.hasOwnProperty(dependency) &&

src/browser/__tests__/ReactBrowserEventEmitter-test.js

@@ -397,10 +397,10 @@ describe('ReactBrowserEventEmitter', function() {
     var setEventListeners = [];
     var listenCalls = EventListener.listen.argsForCall;
     var captureCalls = EventListener.capture.argsForCall;
-    for (var i = 0, l = listenCalls.length; i < l; i++) {
+    for (var i = 0; i < listenCalls.length; i++) {
       setEventListeners.push(listenCalls[i][1]);
     }
-    for (i = 0, l = captureCalls.length; i < l; i++) {
+    for (i = 0; i < captureCalls.length; i++) {
       setEventListeners.push(captureCalls[i][1]);
     }
 
@@ -409,7 +409,7 @@ describe('ReactBrowserEventEmitter', function() {
     var dependencies = module.eventTypes.change.dependencies;
     expect(setEventListeners.length).toEqual(dependencies.length);
 
-    for (i = 0, l = setEventListeners.length; i < l; i++) {
+    for (i = 0; i < setEventListeners.length; i++) {
       expect(dependencies.indexOf(setEventListeners[i])).toBeTruthy();
     }
   });

src/browser/ui/ReactEventListener.js

@@ -74,7 +74,7 @@ function handleTopLevelImpl(bookKeeping) {
     ancestor = findParent(ancestor);
   }
 
-  for (var i = 0, l = bookKeeping.ancestors.length; i < l; i++) {
+  for (var i = 0; i < bookKeeping.ancestors.length; i++) {
     topLevelTarget = bookKeeping.ancestors[i];
     var topLevelTargetID = ReactMount.getID(topLevelTarget) || '';
     ReactEventListener._handleTopLevel(

src/browser/ui/dom/components/ReactDOMInput.js

@@ -141,7 +141,7 @@ var ReactDOMInput = ReactClass.createClass({
       var group = queryRoot.querySelectorAll(
         'input[name=' + JSON.stringify('' + name) + '][type="radio"]');
 
-      for (var i = 0, groupLen = group.length; i < groupLen; i++) {
+      for (var i = 0; i < group.length; i++) {
         var otherNode = group[i];
         if (otherNode === rootNode ||
             otherNode.form !== rootNode.form) {

src/browser/ui/dom/components/ReactDOMSelect.js

@@ -70,10 +70,10 @@ function updateOptions(component, propValue) {
 
   if (component.props.multiple) {
     selectedValue = {};
-    for (i = 0, l = propValue.length; i < l; i++) {
+    for (i = 0; i < propValue.length; i++) {
       selectedValue['' + propValue[i]] = true;
     }
-    for (i = 0, l = options.length; i < l; i++) {
+    for (i = 0; i < options.length; i++) {
       var selected = selectedValue.hasOwnProperty(options[i].value);
       if (options[i].selected !== selected) {
         options[i].selected = selected;
@@ -83,7 +83,7 @@ function updateOptions(component, propValue) {
     // Do not set `select.value` as exact behavior isn't consistent across all
     // browsers for all cases.
     selectedValue = '' + propValue;
-    for (i = 0, l = options.length; i < l; i++) {
+    for (i = 0; i < options.length; i++) {
       if (options[i].value === selectedValue) {
         options[i].selected = true;
         return;

src/event/EventPluginHub.js

@@ -233,7 +233,7 @@ var EventPluginHub = {
       nativeEvent) {
     var events;
     var plugins = EventPluginRegistry.plugins;
-    for (var i = 0, l = plugins.length; i < l; i++) {
+    for (var i = 0; i < plugins.length; i++) {
       // Not every plugin in the ordering may be loaded at runtime.
       var possiblePlugin = plugins[i];
       if (possiblePlugin) {

src/utils/CallbackQueue.js

@@ -64,7 +64,7 @@ assign(CallbackQueue.prototype, {
       );
       this._callbacks = null;
       this._contexts = null;
-      for (var i = 0, l = callbacks.length; i < l; i++) {
+      for (var i = 0; i < callbacks.length; i++) {
         callbacks[i].call(contexts[i]);
       }
       callbacks.length = 0;