Skip to content

Commit c3a2c4b

Browse files
author
Brian Vaughn
committed
Add more test gating to fix broken targets
1 parent 76f26f6 commit c3a2c4b

File tree

2 files changed

+21
-10
lines changed

2 files changed

+21
-10
lines changed

packages/react-dom/src/__tests__/ReactDOMServerIntegrationModes-test.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,10 @@ describe('ReactDOMServerIntegration', () => {
4040
});
4141

4242
// Test pragmas don't support itRenders abstraction
43-
if (require('shared/ReactFeatureFlags').enableDebugTracing) {
43+
if (
44+
__EXPERIMENTAL__ &&
45+
require('shared/ReactFeatureFlags').enableDebugTracing
46+
) {
4447
describe('React.DebugTracingMode', () => {
4548
beforeEach(() => {
4649
spyOnDevAndProd(console, 'log');

packages/react-reconciler/src/__tests__/DebugTracing-test.internal.js

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ describe('DebugTracing', () => {
4040
});
4141
});
4242

43+
// @gate experimental
4344
it('should not log anything for sync render without suspends or state updates', () => {
4445
ReactTestRenderer.create(
4546
<React.DebugTracingMode>
@@ -50,8 +51,14 @@ describe('DebugTracing', () => {
5051
expect(logs).toEqual([]);
5152
});
5253

54+
// @gate experimental
5355
it('should not log anything for concurrent render without suspends or state updates', () => {
54-
ReactTestRenderer.create(<div />, {unstable_isConcurrent: true});
56+
ReactTestRenderer.create(
57+
<React.DebugTracingMode>
58+
<div />
59+
</React.DebugTracingMode>,
60+
{unstable_isConcurrent: true},
61+
);
5562

5663
expect(logs).toEqual([]);
5764

@@ -62,7 +69,7 @@ describe('DebugTracing', () => {
6269
expect(logs).toEqual([]);
6370
});
6471

65-
// @gate enableDebugTracing
72+
// @gate experimental && enableDebugTracing
6673
it('should log sync render with suspense', async () => {
6774
const fakeSuspensPromise = Promise.resolve(true);
6875
function Example() {
@@ -89,7 +96,7 @@ describe('DebugTracing', () => {
8996
expect(logs).toEqual(['log: ⚛️ Example resolved']);
9097
});
9198

92-
// @gate enableDebugTracing
99+
// @gate experimental && enableDebugTracing
93100
it('should log concurrent render with suspense', async () => {
94101
const fakeSuspensPromise = Promise.resolve(true);
95102
function Example() {
@@ -123,7 +130,7 @@ describe('DebugTracing', () => {
123130
expect(logs).toEqual(['log: ⚛️ Example resolved']);
124131
});
125132

126-
// @gate enableDebugTracing
133+
// @gate experimental && enableDebugTracing
127134
it('should log cascading class component updates', () => {
128135
class Example extends React.Component {
129136
state = {didMount: false};
@@ -157,7 +164,7 @@ describe('DebugTracing', () => {
157164
]);
158165
});
159166

160-
// @gate enableDebugTracing
167+
// @gate experimental && enableDebugTracing
161168
it('should log render phase state updates for class component', () => {
162169
class Example extends React.Component {
163170
state = {didRender: false};
@@ -192,7 +199,7 @@ describe('DebugTracing', () => {
192199
]);
193200
});
194201

195-
// @gate enableDebugTracing
202+
// @gate experimental && enableDebugTracing
196203
it('should log cascading layout updates', () => {
197204
function Example() {
198205
const [didMount, setDidMount] = React.useState(false);
@@ -224,7 +231,7 @@ describe('DebugTracing', () => {
224231
]);
225232
});
226233

227-
// @gate enableDebugTracing
234+
// @gate experimental && enableDebugTracing
228235
it('should log cascading passive updates', () => {
229236
function Example() {
230237
const [didMount, setDidMount] = React.useState(false);
@@ -249,7 +256,7 @@ describe('DebugTracing', () => {
249256
]);
250257
});
251258

252-
// @gate enableDebugTracing
259+
// @gate experimental && enableDebugTracing
253260
it('should log render phase updates', () => {
254261
function Example() {
255262
const [didRender, setDidRender] = React.useState(false);
@@ -275,7 +282,7 @@ describe('DebugTracing', () => {
275282
]);
276283
});
277284

278-
// @gate enableDebugTracing
285+
// @gate experimental && enableDebugTracing
279286
it('should log when user code logs', () => {
280287
function Example() {
281288
console.log('Hello from user code');
@@ -302,6 +309,7 @@ describe('DebugTracing', () => {
302309
]);
303310
});
304311

312+
// @gate experimental
305313
it('should not log anything outside of a DebugTracingMode subtree', () => {
306314
function ExampleThatCascades() {
307315
const [didMount, setDidMount] = React.useState(false);

0 commit comments

Comments
 (0)