Skip to content

Commit dfe8b08

Browse files
committed
Legacy renderToString should not support top level Suspense
1 parent 0eaab16 commit dfe8b08

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

packages/react-dom-bindings/src/server/ReactFizzConfigDOMLegacy.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,6 @@ export {
172172
completeResumableState,
173173
emitEarlyPreloads,
174174
supportsClientAPIs,
175-
canHavePreamble,
176175
hoistPreambleState,
177176
isPreambleReady,
178177
isPreambleContext,
@@ -194,6 +193,10 @@ export function getViewTransitionFormatContext(
194193
return parentContext;
195194
}
196195

196+
export function canHavePreamble(): boolean {
197+
return false;
198+
}
199+
197200
export function pushTextInstance(
198201
target: Array<Chunk | PrecomputedChunk>,
199202
text: string,

packages/react-dom/src/__tests__/ReactDOMServerPartialHydration-test.internal.js

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2444,16 +2444,14 @@ describe('ReactDOMServerPartialHydration', () => {
24442444

24452445
function App({showMore}) {
24462446
return (
2447-
<div>
2448-
<SuspenseList revealOrder="together">
2449-
{a}
2450-
{showMore ? (
2451-
<Suspense fallback="Loading B">
2452-
<AlwaysSuspend />
2453-
</Suspense>
2454-
) : null}
2455-
</SuspenseList>
2456-
</div>
2447+
<SuspenseList revealOrder="together">
2448+
{a}
2449+
{showMore ? (
2450+
<Suspense fallback="Loading B">
2451+
<AlwaysSuspend />
2452+
</Suspense>
2453+
) : null}
2454+
</SuspenseList>
24572455
);
24582456
}
24592457

0 commit comments

Comments
 (0)