Skip to content

Commit ea3cccd

Browse files
committed
Try the new thing
1 parent aca9c8a commit ea3cccd

File tree

2 files changed

+25
-68
lines changed

2 files changed

+25
-68
lines changed

packages/react/src/__tests__/ReactElementJSX-test.js

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -351,6 +351,31 @@ describe('ReactElement.jsx', () => {
351351
);
352352
});
353353

354+
if (require('shared/ReactFeatureFlags').warnAboutSpreadingKeyToJSX) {
355+
it('should warn when keys are passed as part of props', () => {
356+
const container = document.createElement('div');
357+
class Child extends React.Component {
358+
render() {
359+
return React.jsx('div', {});
360+
}
361+
}
362+
class Parent extends React.Component {
363+
render() {
364+
return React.jsx('div', {
365+
children: [React.jsx(Child, {key: '0'})],
366+
});
367+
}
368+
}
369+
expect(() =>
370+
ReactDOM.render(React.jsx(Parent, {}), container),
371+
).toErrorDev(
372+
'Warning: React.jsx: Spreading a key to JSX is a deprecated pattern. ' +
373+
'Explicitly pass a key after spreading props in your JSX call. ' +
374+
'E.g. <Child {...props} key={key} />',
375+
);
376+
});
377+
}
378+
354379
it('should not warn when unkeyed children are passed to jsxs', () => {
355380
const container = document.createElement('div');
356381
class Child extends React.Component {

packages/react/src/__tests__/ReactElementJSXNewWarnings-test.internal.js

Lines changed: 0 additions & 68 deletions
This file was deleted.

0 commit comments

Comments
 (0)