Skip to content

Commit ea5df46

Browse files
committed
Remove createRootStrictEffectsByDefault flag (#28102)
There's no need to separate strict mode from strict effects mode any more. I didn't clean up the `StrictEffectMode` fiber flag, because it's used to prevent strict effects in legacy mode. I could replace those checks with `LegacyMode` checks, but when we remove legacy mode, we can remove that flag and condense them into one StrictMode flag away. DiffTrain build for commit 3d1da1f.
1 parent e12f0de commit ea5df46

File tree

9 files changed

+17
-20
lines changed

9 files changed

+17
-20
lines changed

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<bd897fcea644b2a95f4293822e1f08be>>
10+
* @generated SignedSource<<fdc597b6fd2e169218abbcc3fbb6bc8c>>
1111
*/
1212

1313
"use strict";
@@ -142,7 +142,6 @@ if (__DEV__) {
142142
var enableProfilerTimer = true;
143143
var enableProfilerCommitHooks = true;
144144
var enableProfilerNestedUpdatePhase = true;
145-
var createRootStrictEffectsByDefault = false;
146145
var syncLaneExpirationMs = 250;
147146
var transitionLaneExpirationMs = 5000;
148147
var enableLazyContextPropagation = false;
@@ -25204,7 +25203,7 @@ if (__DEV__) {
2520425203
if (tag === ConcurrentRoot) {
2520525204
mode = ConcurrentMode;
2520625205

25207-
if (isStrictMode === true || createRootStrictEffectsByDefault) {
25206+
if (isStrictMode === true) {
2520825207
mode |= StrictLegacyMode | StrictEffectsMode;
2520925208
}
2521025209

@@ -25623,7 +25622,7 @@ if (__DEV__) {
2562325622
return root;
2562425623
}
2562525624

25626-
var ReactVersion = "18.3.0-canary-4dd475c97-20240201";
25625+
var ReactVersion = "18.3.0-canary-3d1da1f9a-20240201";
2562725626

2562825627
// Might add PROFILE later.
2562925628

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9149,7 +9149,7 @@ var devToolsConfig$jscomp$inline_1031 = {
91499149
throw Error("TestRenderer does not support findFiberByHostInstance()");
91509150
},
91519151
bundleType: 0,
9152-
version: "18.3.0-canary-4dd475c97-20240201",
9152+
version: "18.3.0-canary-3d1da1f9a-20240201",
91539153
rendererPackageName: "react-test-renderer"
91549154
};
91559155
var internals$jscomp$inline_1207 = {
@@ -9180,7 +9180,7 @@ var internals$jscomp$inline_1207 = {
91809180
scheduleRoot: null,
91819181
setRefreshHandler: null,
91829182
getCurrentFiber: null,
9183-
reconcilerVersion: "18.3.0-canary-4dd475c97-20240201"
9183+
reconcilerVersion: "18.3.0-canary-3d1da1f9a-20240201"
91849184
};
91859185
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
91869186
var hook$jscomp$inline_1208 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9577,7 +9577,7 @@ var devToolsConfig$jscomp$inline_1073 = {
95779577
throw Error("TestRenderer does not support findFiberByHostInstance()");
95789578
},
95799579
bundleType: 0,
9580-
version: "18.3.0-canary-4dd475c97-20240201",
9580+
version: "18.3.0-canary-3d1da1f9a-20240201",
95819581
rendererPackageName: "react-test-renderer"
95829582
};
95839583
var internals$jscomp$inline_1248 = {
@@ -9608,7 +9608,7 @@ var internals$jscomp$inline_1248 = {
96089608
scheduleRoot: null,
96099609
setRefreshHandler: null,
96109610
getCurrentFiber: null,
9611-
reconcilerVersion: "18.3.0-canary-4dd475c97-20240201"
9611+
reconcilerVersion: "18.3.0-canary-3d1da1f9a-20240201"
96129612
};
96139613
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
96149614
var hook$jscomp$inline_1249 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (__DEV__) {
2424
) {
2525
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
2626
}
27-
var ReactVersion = "18.3.0-canary-4dd475c97-20240201";
27+
var ReactVersion = "18.3.0-canary-3d1da1f9a-20240201";
2828

2929
// ATTENTION
3030
// When adding new symbols to this file,

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -545,4 +545,4 @@ exports.useSyncExternalStore = function (
545545
exports.useTransition = function () {
546546
return ReactCurrentDispatcher.current.useTransition();
547547
};
548-
exports.version = "18.3.0-canary-4dd475c97-20240201";
548+
exports.version = "18.3.0-canary-3d1da1f9a-20240201";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ exports.useSyncExternalStore = function (
541541
exports.useTransition = function () {
542542
return ReactCurrentDispatcher.current.useTransition();
543543
};
544-
exports.version = "18.3.0-canary-4dd475c97-20240201";
544+
exports.version = "18.3.0-canary-3d1da1f9a-20240201";
545545
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
546546
"function" ===
547547
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
4dd475c97799f3fb83bdd2fff2d028e0e30041cf
1+
3d1da1f9ab7d54984c096e6a04c8729f3a50fd8a

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<b9de33ad77303e612467451dba484b4f>>
10+
* @generated SignedSource<<23d1b7cce95eeba5b7251f184412d23c>>
1111
*/
1212

1313
"use strict";
@@ -3247,7 +3247,6 @@ to return true:wantsResponderID| |
32473247
var enableProfilerNestedUpdatePhase = true;
32483248
var syncLaneExpirationMs = 250;
32493249
var transitionLaneExpirationMs = 5000;
3250-
var createRootStrictEffectsByDefault = false;
32513250
var enableLazyContextPropagation = false;
32523251
var enableAsyncActions = false;
32533252

@@ -27378,7 +27377,7 @@ to return true:wantsResponderID| |
2737827377
if (tag === ConcurrentRoot) {
2737927378
mode = ConcurrentMode;
2738027379

27381-
if (isStrictMode === true || createRootStrictEffectsByDefault) {
27380+
if (isStrictMode === true) {
2738227381
mode |= StrictLegacyMode | StrictEffectsMode;
2738327382
}
2738427383

@@ -27856,7 +27855,7 @@ to return true:wantsResponderID| |
2785627855
return root;
2785727856
}
2785827857

27859-
var ReactVersion = "18.3.0-canary-a4243e8c";
27858+
var ReactVersion = "18.3.0-canary-e1f5390e";
2786027859

2786127860
function createPortal$1(
2786227861
children,

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<ba7079d4e2b3c30850f1187f2cda38c9>>
10+
* @generated SignedSource<<901a1526ca77447e4134b09fdc38f5d6>>
1111
*/
1212

1313
"use strict";
@@ -2955,7 +2955,6 @@ to return true:wantsResponderID| |
29552955
var enableProfilerNestedUpdatePhase = true;
29562956
var syncLaneExpirationMs = 250;
29572957
var transitionLaneExpirationMs = 5000;
2958-
var createRootStrictEffectsByDefault = false;
29592958
var enableLazyContextPropagation = false;
29602959
var enableAsyncActions = false;
29612960

@@ -27819,7 +27818,7 @@ to return true:wantsResponderID| |
2781927818
if (tag === ConcurrentRoot) {
2782027819
mode = ConcurrentMode;
2782127820

27822-
if (isStrictMode === true || createRootStrictEffectsByDefault) {
27821+
if (isStrictMode === true) {
2782327822
mode |= StrictLegacyMode | StrictEffectsMode;
2782427823
}
2782527824

@@ -28297,7 +28296,7 @@ to return true:wantsResponderID| |
2829728296
return root;
2829828297
}
2829928298

28300-
var ReactVersion = "18.3.0-canary-a490d791";
28299+
var ReactVersion = "18.3.0-canary-4393a1cb";
2830128300

2830228301
function createPortal$1(
2830328302
children,

0 commit comments

Comments
 (0)