[compiler] Add support for diagnostic hints (#34126)

Hints are meant as additional information to present to the developer
about an error. The first use-case here is for the suggestion to name
refs with "-Ref" if we encounter a mutation that looks like it might be
a ref. The original error printing used a second error detail which
printed the source code twice, a hint with just extra text is less
noisy.

DiffTrain build for [6ffcac8](6ffcac8)

Author: josephsavona

compiled/eslint-plugin-react-hooks/index.js

@@ -17650,8 +17650,10 @@ class CompilerDiagnostic {
         return this;
     }
     primaryLocation() {
-        var _a, _b;
-        return (_b = (_a = this.options.details.filter(d => d.kind === 'error')[0]) === null || _a === void 0 ? void 0 : _a.loc) !== null && _b !== void 0 ? _b : null;
+        const firstErrorDetail = this.options.details.filter(d => d.kind === 'error')[0];
+        return firstErrorDetail != null && firstErrorDetail.kind === 'error'
+            ? firstErrorDetail.loc
+            : null;
     }
     printErrorMessage(source, options) {
         const buffer = [
@@ -17684,8 +17686,13 @@ class CompilerDiagnostic {
                     buffer.push(codeFrame);
                     break;
                 }
+                case 'hint': {
+                    buffer.push('\n\n');
+                    buffer.push(detail.message);
+                    break;
+                }
                 default: {
-                    assertExhaustive$1(detail.kind, `Unexpected detail kind ${detail.kind}`);
+                    assertExhaustive$1(detail, `Unexpected detail kind ${detail.kind}`);
                 }
             }
         }
@@ -42154,8 +42161,7 @@ function applySignature(context, state, signature, instruction) {
                         if (effect.kind === 'Mutate' &&
                             ((_b = effect.reason) === null || _b === void 0 ? void 0 : _b.kind) === 'AssignCurrentProperty') {
                             diagnostic.withDetail({
-                                kind: 'error',
-                                loc: effect.value.loc,
+                                kind: 'hint',
                                 message: `Hint: If this value is a Ref (value returned by \`useRef()\`), rename the variable to end in "Ref".`,
                             });
                         }
@@ -42583,8 +42589,7 @@ function applyEffect(context, state, _effect, initialized, effects) {
                     if (effect.kind === 'Mutate' &&
                         ((_e = effect.reason) === null || _e === void 0 ? void 0 : _e.kind) === 'AssignCurrentProperty') {
                         diagnostic.withDetail({
-                            kind: 'error',
-                            loc: effect.value.loc,
+                            kind: 'hint',
                             message: `Hint: If this value is a Ref (value returned by \`useRef()\`), rename the variable to end in "Ref".`,
                         });
                     }

compiled/facebook-www/REVISION

@@ -1 +1 @@
-724b324b966343f08ff0cb16ec9d8013e3891dfd
+6ffcac8558efbd204c7df5d52787a90e507dd8d7

compiled/facebook-www/REVISION_TRANSFORMS

@@ -1 +1 @@
-724b324b966343f08ff0cb16ec9d8013e3891dfd
+6ffcac8558efbd204c7df5d52787a90e507dd8d7

compiled/facebook-www/React-dev.classic.js

@@ -1409,7 +1409,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.2.0-www-classic-724b324b-20250815";
+    exports.version = "19.2.0-www-classic-6ffcac85-20250815";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

@@ -1409,7 +1409,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.2.0-www-modern-724b324b-20250815";
+    exports.version = "19.2.0-www-modern-6ffcac85-20250815";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

@@ -600,4 +600,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-classic-724b324b-20250815";
+exports.version = "19.2.0-www-classic-6ffcac85-20250815";

compiled/facebook-www/React-prod.modern.js

@@ -600,4 +600,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-modern-724b324b-20250815";
+exports.version = "19.2.0-www-modern-6ffcac85-20250815";

compiled/facebook-www/React-profiling.classic.js

@@ -604,7 +604,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-classic-724b324b-20250815";
+exports.version = "19.2.0-www-classic-6ffcac85-20250815";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

@@ -604,7 +604,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-modern-724b324b-20250815";
+exports.version = "19.2.0-www-modern-6ffcac85-20250815";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

@@ -19588,10 +19588,10 @@ __DEV__ &&
     (function () {
       var internals = {
         bundleType: 1,
-        version: "19.2.0-www-classic-724b324b-20250815",
+        version: "19.2.0-www-classic-6ffcac85-20250815",
         rendererPackageName: "react-art",
         currentDispatcherRef: ReactSharedInternals,
-        reconcilerVersion: "19.2.0-www-classic-724b324b-20250815"
+        reconcilerVersion: "19.2.0-www-classic-6ffcac85-20250815"
       };
       internals.overrideHookState = overrideHookState;
       internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -19625,7 +19625,7 @@ __DEV__ &&
     exports.Shape = Shape;
     exports.Surface = Surface;
     exports.Text = Text;
-    exports.version = "19.2.0-www-classic-724b324b-20250815";
+    exports.version = "19.2.0-www-classic-6ffcac85-20250815";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&