Log Custom Reason for the Suspended Commit Track #34522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
requested review from
eps1lon,
hoxyq,
jackpope and
rickhanlonii
github-actions
bot
added
the
React Core Team
sebmarkbage
force-pushed
the
vtsuspendedcommit
branch
from
60ac750 to
a73fd1d
Compare
sebmarkbage
commented
Sep 18, 2025
| rootContainer: Container, | ||
| ): null | string { | ||
| if (state.waitingForViewTransition) { | ||
| return 'Waiting for the previous Animation'; |
There was a problem hiding this comment.
If the previous animation finishes before the css and images do, then technically after that we were suspended on css. But that's a nuance that would require more complexity to show.
Technically if we were suspended on CSS first and then it finishes and then we were only suspended on images we should also show two tracks but that's unnecessary detail.
eps1lon
approved these changes
Sep 20, 2025
| } | ||
|
|
||
| export function getSuspendedCommitReason(state, rootContainer) { | ||
| return ''; |
There was a problem hiding this comment.
Isn't this supposed to return null?
There was a problem hiding this comment.
Originally I had this as required to return a string since we are always going to delay in this path so not providing a reason would be an error. However, I ended up just returning null in the DOM but maybe that should just throw instead.
sebmarkbage
force-pushed
the
vtsuspendedcommit
branch
from
a73fd1d to
bb6391d
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Sep 20, 2025
Stacked on #34511. We currently log all Suspended Commit as "Suspended on Images or CSS" but it can really be other reasons too now. Like waiting on the previous View Transition. This allows the host config configure this reason. Now when one animation starts before another one finishes we log that as "Waiting for the previous Animation". <img width="592" height="257" alt="Screenshot 2025-09-17 at 11 53 45 PM" src="https://github.com/user-attachments/assets/817af8b5-37ae-46d8-bfd1-cd3fc637f3f3" /> DiffTrain build for [b204edd](b204edd)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 20, 2025
Stacked on #34511. We currently log all Suspended Commit as "Suspended on Images or CSS" but it can really be other reasons too now. Like waiting on the previous View Transition. This allows the host config configure this reason. Now when one animation starts before another one finishes we log that as "Waiting for the previous Animation". <img width="592" height="257" alt="Screenshot 2025-09-17 at 11 53 45 PM" src="https://github.com/user-attachments/assets/817af8b5-37ae-46d8-bfd1-cd3fc637f3f3" /> DiffTrain build for [b204edd](b204edd)
sebmarkbage
added a commit
that referenced
this pull request
Sep 20, 2025
Stacked on #34522. <img width="1025" height="200" alt="Screenshot 2025-09-19 at 6 37 28 PM" src="https://github.com/user-attachments/assets/f25900f6-6503-48b1-876d-bd6697a29c6f" /> We already cover the time between "Starting Animation" and "Remaining Effects" as "Animating". However, if the effects are forced then we can still be animating after that. This fills in that gap. This also fills in the gap if another render starts before the animation finishes on the same track. It'll mark the blank space between the previous render finishing and the next render starting as "Animating". This should correspond roughly to the native "Animations" track.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 20, 2025
Stacked on #34522. <img width="1025" height="200" alt="Screenshot 2025-09-19 at 6 37 28 PM" src="https://github.com/user-attachments/assets/f25900f6-6503-48b1-876d-bd6697a29c6f" /> We already cover the time between "Starting Animation" and "Remaining Effects" as "Animating". However, if the effects are forced then we can still be animating after that. This fills in that gap. This also fills in the gap if another render starts before the animation finishes on the same track. It'll mark the blank space between the previous render finishing and the next render starting as "Animating". This should correspond roughly to the native "Animations" track. DiffTrain build for [b4fe1e6](b4fe1e6)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 20, 2025
Stacked on #34522. <img width="1025" height="200" alt="Screenshot 2025-09-19 at 6 37 28 PM" src="https://github.com/user-attachments/assets/f25900f6-6503-48b1-876d-bd6697a29c6f" /> We already cover the time between "Starting Animation" and "Remaining Effects" as "Animating". However, if the effects are forced then we can still be animating after that. This fills in that gap. This also fills in the gap if another render starts before the animation finishes on the same track. It'll mark the blank space between the previous render finishing and the next render starting as "Animating". This should correspond roughly to the native "Animations" track. DiffTrain build for [b4fe1e6](b4fe1e6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #34511.
We currently log all Suspended Commit as "Suspended on Images or CSS" but it can really be other reasons too now. Like waiting on the previous View Transition. This allows the host config configure this reason.
Now when one animation starts before another one finishes we log that as "Waiting for the previous Animation".