Skip to content

Forms Update #8112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 26, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 31 additions & 25 deletions docs/docs/forms.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,11 @@ render() {
}
```

User input has no effect on the rendered element because React has declared the value to be "Hello!". To update the value in response to user input, you would use the onChange event:
User input has no effect on the rendered element because React has declared the value to be "Hello!".

```javascript
To update the value in response to user input, you would use the `onChange` event to save the new value, then pass that to the `value` prop of the form:

```javascript{10,22,23}
class Form extends React.Component {
constructor(props) {
super(props);
Expand Down Expand Up @@ -91,9 +93,9 @@ An **uncontrolled** component manages its own state.
}
```

If you wanted to listen to updates to the value, you could use the `onChange` event just like you can with controlled components.
If you wanted to listen to updates to the value, you could use the `onChange` event just like you can with controlled components. However, you would _not_ pass the value you saved to the component.

```javascript
```javascript{10,22}
class Form extends React.Component {
constructor(props) {
super(props);
Expand All @@ -115,7 +117,6 @@ class Form extends React.Component {
<div>
<input type="text"
placeholder="Hello!"
value={this.state.value}
onChange={this.handleChange} />
<button onClick={this.handleSubmit}>Submit</button>
</div>
Expand Down Expand Up @@ -226,7 +227,7 @@ For instance, if you want to imperatively submit a form, one approach would be t

## Examples

### Basic Text Input
### Basic Controlled Input

```javascript
class Form extends React.Component {
Expand All @@ -236,7 +237,6 @@ class Form extends React.Component {
this.handleChange = this.handleChange.bind(this);
this.handleSubmit = this.handleSubmit.bind(this);
}

handleChange(event) {
this.setState({value: event.target.value});
}
Expand All @@ -262,7 +262,7 @@ ReactDOM.render(<Form />, document.getElementById('root'));
[Try this on CodePen.](https://codepen.io/ericnakagawa/pen/JRmZjz?editors=0010)


### Basic Textarea
### Basic Controlled Textarea

```javascript
class Form extends React.Component {
Expand Down Expand Up @@ -300,7 +300,7 @@ ReactDOM.render(<Form />, document.getElementById('root'));

[Try this on CodePen.](https://codepen.io/ericnakagawa/pen/kkAQPp?editors=0010)

### Basic Select
### Basic Uncontrolled Select

```javascript
class Form extends React.Component {
Expand Down Expand Up @@ -360,9 +360,12 @@ class Form extends React.Component {
render() {
return (
<div>
<input type="radio" name="choice" value="A" onChange={this.handleChange} /> Option A<br />
<input type="radio" name="choice" value="B" onChange={this.handleChange} defaultChecked={true} /> Option B<br />
<input type="radio" name="choice" value="C" onChange={this.handleChange} /> Option C<br />
<input type="radio" name="choice" value="A"
onChange={this.handleChange} /> Option A<br />
<input type="radio" name="choice" value="B"
onChange={this.handleChange} defaultChecked={true} /> Option B<br />
<input type="radio" name="choice" value="C"
onChange={this.handleChange} /> Option C<br />
<br />
<button onClick={this.handleSubmit}>Submit</button>
</div>
Expand All @@ -376,38 +379,41 @@ ReactDOM.render(<Form />, document.getElementById('root'));
[Try this on CodePen.](https://codepen.io/ericnakagawa/pen/WGaYVg?editors=0010)


### Basic Checkbox
### Basic Uncontrolled Checkbox

```javascript
class Form extends React.Component {
constructor(props) {
super(props);
this.state = {checked: ["B"]};
this.state = {checked: {"A": false, "B": true, "C": false}};
this.handleChange = this.handleChange.bind(this);
this.handleSubmit = this.handleSubmit.bind(this);
}

handleChange(event) {
let val = event.target.value;
let checked = this.state.checked.slice(); // copy
if(checked.includes(val)) {
checked.splice(checked.indexOf(val), 1);
} else {
checked.push(val);
}
let value = event.target.value;
let checked = this.state.checked; // copy
if (!checked[value]) { checked[value] = true; } else { checked[value] = false; }
this.setState({checked: checked})
}

handleSubmit(event) {
alert("Boxes checked are: '" + this.state.checked + "'");
alert("Boxes checked: " +
(this.state.checked.A ? "A " : "") +
(this.state.checked.B ? "B " : "") +
(this.state.checked.C ? "C" : "")
);
}

render() {
return (
<div>
<input type="checkbox" value="A" onChange={this.handleChange} /> Option A<br />
<input type="checkbox" value="B" onChange={this.handleChange} defaultChecked={true} /> Option B<br />
<input type="checkbox" value="C" onChange={this.handleChange} /> Option C<br />
<input type="checkbox" value="A"
onChange={this.handleChange} /> Option A<br />
<input type="checkbox" value="B"
onChange={this.handleChange} defaultChecked={true} /> Option B<br />
<input type="checkbox" value="C"
onChange={this.handleChange} /> Option C<br />
<br />
<button onClick={this.handleSubmit}>Submit</button>
</div>
Expand Down